Bug 19692

Summary: Unclosed div in opac-shelves.tt
Product: Koha Reporter: Victor Grousset/tuxayo <victor>
Component: TemplatesAssignee: Simon Pouchol <simon.pouchol>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: dominic.pichette, fridolin.somers, jonathan.druart, m.de.rooy, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 19692 : fix unclosed div in opac-shelves.tt
Bug 19692 : fix unclosed div in opac-shelves.tt
Bug 19692 : fix unclosed div in opac-shelves.tt
Bug 19692 : fix unclosed div in opac-shelves.tt

Description Victor Grousset/tuxayo 2017-11-24 15:51:55 UTC
It was found when customizing an instance.

The comment makes it clear that it should be a closing tag.

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt;hb=570eb4026642f71e462c7746a9c91721aa9334c1#l725
Comment 1 Victor Grousset/tuxayo 2017-11-24 16:02:58 UTC
Created attachment 69336 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page
Comment 2 Dominic Pichette 2017-11-24 19:19:56 UTC
Created attachment 69337 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Comment 3 Marcel de Rooy 2017-11-27 13:04:36 UTC
Created attachment 69376 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Victor Grousset/tuxayo 2017-11-27 13:27:32 UTC
Created attachment 69379 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Victor Grousset/tuxayo 2017-11-27 13:29:17 UTC
I've changed the author of the commit to Simon Pouchol (the work was on my machine).
That might be their first contribution to the codebase, that's why it might matters :)
Comment 6 Jonathan Druart 2017-12-07 12:38:54 UTC
Patch has been pushed to master for 18.05.
Congratulations Simon for your first patch in!
Comment 7 Victor Grousset/tuxayo 2017-12-08 13:26:46 UTC
Hooray :D
Comment 8 Nick Clemens 2017-12-14 12:31:21 UTC
Pushed to stable for 17.11.01, awesome work all!
Comment 9 Fridolin Somers 2017-12-20 08:29:54 UTC
Pushed to 17.05.x, will be in v17.05.07