Summary: | OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Web services | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | dominic.pichette, fridolin.somers, jonathan.druart, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 19724 | ||
Bug Blocks: | |||
Attachments: |
Bug 19725: Add failing test
Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Bug 19725: Add failing test Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Bug 19725: Add failing test Bug 19725: OAI-PMH - Use biblio_metadata.timestamp |
Description
Julian Maurice
2017-12-01 13:09:07 UTC
Created attachment 69437 [details] [review] Bug 19725: Add failing test Also fix tests for UNIMARC Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it FAILS Created attachment 69438 [details] [review] Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it SUCCEEDS Sorry, prove t/db_dependent/OAI/Server.t t/db_dependent/OAI/Server.t .. 1/29 Can't locate object method "xslt" via package "Koha::OAI::Server::ListMetadataFormats" at Koha/OAI/Server/Repository.pm line 147. # Looks like your test exited with 2 just after 12. t/db_dependent/OAI/Server.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 17/29 subtests Test Summary Report ------------------- t/db_dependent/OAI/Server.t (Wstat: 512 Tests: 12 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 29 tests but ran 12. Files=1, Tests=12, 72 wallclock secs ( 0.03 usr 0.01 sys + 1.27 cusr 0.10 csys = 1.41 CPU) Result: FAIL This error is caused by a too recent version of HTTP::OAI. See bug 19732 Quick fix: sudo cpanm https://cpan.metacpan.org/authors/id/T/TI/TIMBRODY/HTTP-OAI-3.28.tar.gz Created attachment 69627 [details] [review] Bug 19725: Add failing test Also fix tests for UNIMARC Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it FAILS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 69628 [details] [review] Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it SUCCEEDS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 69997 [details] [review] Bug 19725: Add failing test Also fix tests for UNIMARC Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it FAILS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 69998 [details] [review] Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it SUCCEEDS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 |