Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. We need to know the last modification time of the MARC record for some features (like OAI-PMH parameters 'from' and 'until' for instance)
Created attachment 69431 [details] [review] Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. We need to know the last modification time of the MARC record for some features (like OAI-PMH parameters 'from' and 'until' for instance) This patch only adds the missing column in biblio_metadata and deletedbiblio_metadata Test plan: 1. Run updatedatabase.pl 2. Verify that both tables have the new column, its value should be the greatest timestamp value from the corresponding biblio and biblioitems table entries You can verify with the following SQL query: SELECT b.biblionumber, b.timestamp as biblio_ts, bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts FROM biblio_metadata m LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber) LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber);
Created attachment 69457 [details] [review] Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. We need to know the last modification time of the MARC record for some features (like OAI-PMH parameters 'from' and 'until' for instance) This patch only adds the missing column in biblio_metadata and deletedbiblio_metadata Test plan: 1. Run updatedatabase.pl 2. Verify that both tables have the new column, its value should be the greatest timestamp value from the corresponding biblio and biblioitems table entries You can verify with the following SQL query: SELECT b.biblionumber, b.timestamp as biblio_ts, bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts FROM biblio_metadata m LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber) LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber); Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
*** Bug 19555 has been marked as a duplicate of this bug. ***
Created attachment 69478 [details] [review] Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. We need to know the last modification time of the MARC record for some features (like OAI-PMH parameters 'from' and 'until' for instance) This patch only adds the missing column in biblio_metadata and deletedbiblio_metadata Test plan: 1. Run updatedatabase.pl 2. Verify that both tables have the new column, its value should be the greatest timestamp value from the corresponding biblio and biblioitems table entries You can verify with the following SQL query: SELECT b.biblionumber, b.timestamp as biblio_ts, bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts FROM biblio_metadata m LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber) LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber); Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
QA Comment: the function GREATEST is not "standard" but is widely implemented, so no problem here in my opinion
Pushed to master for 18.05, thanks to everybody involved!
Pushed to stable for 17.11.01, awesome work all!
(In reply to Nick Clemens from comment #7) > Pushed to stable for 17.11.01, awesome work all! Your commit in 17.11.x is missing the update of version in Koha.pm
Pushed to 17.05.x, will be in v17.05.07
Resolved since Bug 17196 not in 16.11.x