Bug 19726

Summary: Move admin templates JavaScript to the footer: Preferences
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, josef.moravec, nick, simon.pouchol, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 17858, 14576    
Attachments: Bug 19726 - Move admin templates JavaScript to the footer: Preferences
Bug 19726 - Move admin templates JavaScript to the footer: Preferences
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

Description Owen Leonard 2017-12-01 14:14:22 UTC
In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header.

This patch will do so for system preferences, both standard and local.
Comment 1 Owen Leonard 2017-12-01 14:35:40 UTC Comment hidden (obsolete)
Comment 2 Claire Gravely 2017-12-05 11:14:39 UTC
Created attachment 69500 [details] [review]
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

This patch modifies the staff client's system preferences templates so
that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
both the standard and local use system preferences:

 - WYSIWYG editor
 - Confirmation messages
 - Table sorting
 - Multiple selects (CoceProviders for example)

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Josef Moravec 2017-12-07 09:40:16 UTC
Created attachment 69601 [details] [review]
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

This patch modifies the staff client's system preferences templates so
that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
both the standard and local use system preferences:

 - WYSIWYG editor
 - Confirmation messages
 - Table sorting
 - Multiple selects (CoceProviders for example)

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Jonathan Druart 2017-12-11 14:37:46 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2017-12-14 18:00:33 UTC
Awesome work all! Skipping for 17.11, enhancement.