| Summary: | Preview routing slip is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | fridolin.somers, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19858 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19058 | ||
| Bug Blocks: | 19761 | ||
| Attachments: |
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip Bug 19766: (bug 19058 follow-up) Fix Preview routing slip |
||
Created attachment 69591 [details] [review] Bug 19766: (bug 19058 follow-up) Fix Preview routing slip This patch fixes the following errors: The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace We are calling ->reserve_id on a Koha::Holds set. Test plan: - Serials -> Find subscription -> "Edit routing list" in the sidebar - Add 1+ recipients - Save -> "Save and preview routing slip" Created attachment 69592 [details] [review] Bug 19766: (bug 19058 follow-up) Fix Preview routing slip This patch fixes the following errors: The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace We are calling ->reserve_id on a Koha::Holds set. Test plan: - Serials -> Find subscription -> "Edit routing list" in the sidebar - Add 1+ recipients - Save -> "Save and preview routing slip" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 69593 [details] [review] Bug 19766: (bug 19058 follow-up) Fix Preview routing slip This patch fixes the following errors: The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace We are calling ->reserve_id on a Koha::Holds set. Test plan: - Serials -> Find subscription -> "Edit routing list" in the sidebar - Add 1+ recipients - Save -> "Save and preview routing slip" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.01, awesome work all! We seem to have the same problem in 16.11 - but the patch here doesn't apply and the errors are different: Can't call method "branchname" on an undefined value at /home/vagrant/kohaclone/serials/routing-preview.pl line 69. I will file a new bug report. |
The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace