Summary: | serial-issues.pl is unused and should be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Serials | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | colin.campbell, jonathan.druart, josef.moravec, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 19767: serial-issues.pl is unused and should be removed
Bug 19767: serial-issues.pl is unused and should be removed Bug 19767: serial-issues.pl is unused and should be removed |
Description
Owen Leonard
2017-12-06 19:56:00 UTC
It would be good to get a confirmation from the list Created attachment 69697 [details] [review] Bug 19767: serial-issues.pl is unused and should be removed This patch removes three unused files: serials/serial-issues.pl ...and its associated templates: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt To test, apply the patch and search the Koha codebase for references to any of those files. None should exist. Created attachment 69747 [details] [review] Bug 19767: serial-issues.pl is unused and should be removed This patch removes three unused files: serials/serial-issues.pl ...and its associated templates: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt To test, apply the patch and search the Koha codebase for references to any of those files. None should exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #1) > It would be good to get a confirmation from the list http://lists.koha-community.org/pipermail/koha-devel/2017-December/044196.html Created attachment 69760 [details] [review] Bug 19767: serial-issues.pl is unused and should be removed This patch removes three unused files: serials/serial-issues.pl ...and its associated templates: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt To test, apply the patch and search the Koha codebase for references to any of those files. None should exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Removing dead code is always good ;) Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to stable for 17.11.01 |