Description
Chris Cormack
2010-05-21 00:36:52 UTC
Described behaviour is not available in current versions, so this is still valid. Still valid? Created attachment 45984 [details] [review] Bug 1983: Checkout: Hold request when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify thath the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see near the buttons for Checkin/Checkout a link "Click here to place hold" - Verify that the link is stylable (span class circ-scheckoutplacehold) - Verify that the link takes you to the page for placing holds as appropriate - Do the same for item B and verify that it works for reserved items as well. - Log in with a staff client who has no permission to place holds - Repeat steps above, verify that the link does not appear. Created attachment 45991 [details] [review] Bug 1983: Checkout: Hold request when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify thath the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see near the buttons for Checkin/Checkout a link "Click here to place hold" - Verify that the link is stylable (span class circ-scheckoutplacehold) - Verify that the link takes you to the page for placing holds as appropriate - Do the same for item B and verify that it works for reserved items as well. - Log in with a staff client who has no permission to place holds - Repeat steps above, verify that the link does not appear. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Comment on attachment 45991 [details] [review] Bug 1983: Checkout: Hold request when checking out an item already on loan or reserved Review of attachment 45991 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +408,5 @@ > </form> > > +[% IF ( RESERVE_WAITING ) || ( RESERVED ) || ( ISSUED_TO_ANOTHER ) %] > + [%IF (CAN_user_reserveforothers_place_holds ) %] > + <span class="circ-checkoutplacehold"><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% itembiblionumber %]&findborrower=x">Click here to place hold</a></span> What is this 'x'?? Why a link instead of a button? Oh, there was something missing. Switching bach to assigned. Created attachment 46668 [details] [review] Bug 1983: Checkout: Hold repquest when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify that the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see underneath the buttons for Checkin/Checkout a link with following text: "Click here to place hold for [Patron X' name]" - Verify that the link is stylable (div class circ-scheckoutplacehold) - Verify that the link takes you to the page to place a hold on this biblio for patron Y - Do the same for item B and verify that it works for reserved items as well. - Repeat steps above for a patron who has restrictions, verify that the link does not appear - Log in with a staff member who has no permission to place holds - Repeat steps above for a patron without restrictions, verify that the link does not appear. I refactored the patch (more / changed conditions to display link, give the link correct params). The patch will need a new sign-off. See changed test plan on this patch. Regarding link vs button: For more clarity, I decided for a link below the buttons with a text including the patron's name. Created attachment 46758 [details] [review] Bug 1983: Checkout: Hold repquest when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify that the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see underneath the buttons for Checkin/Checkout a link with following text: "Click here to place hold for [Patron X' name]" - Verify that the link is stylable (div class circ-scheckoutplacehold) - Verify that the link takes you to the page to place a hold on this biblio for patron Y - Do the same for item B and verify that it works for reserved items as well. - Repeat steps above for a patron who has restrictions, verify that the link does not appear - Log in with a staff member who has no permission to place holds - Repeat steps above for a patron without restrictions, verify that the link does not appear. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 46856 [details] [review] Bug 1983: Checkout: Hold repquest when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify that the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see underneath the buttons for Checkin/Checkout a link with following text: "Click here to place hold for [Patron X' name]" - Verify that the link is stylable (div class circ-scheckoutplacehold) - Verify that the link takes you to the page to place a hold on this biblio for patron Y - Do the same for item B and verify that it works for reserved items as well. - Repeat steps above for a patron who has restrictions, verify that the link does not appear - Log in with a staff member who has no permission to place holds - Repeat steps above for a patron without restrictions, verify that the link does not appear. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |