|
Description
Josef Moravec
2017-12-19 09:53:23 UTC
Created attachment 70576 [details] [review] Bug 19833: Kill the "biblios" " 1) Check files modules/about.tt, modules/acqui/booksellers.tt and modules/acqui/invoices.tt for typos nad check that there are no "biblio" and only "biblographic record". Created attachment 70581 [details] [review] Bug 19833: Kill the "biblios" Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" modules/admin/admin-home.tt modules/admin/authtypes.tt modules/admin/checkmarc.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/z3950servers.tt Created attachment 70585 [details] [review] Bug 19833: Kill the "biblios" Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" modules/help/catalogue/search-history.tt modules/help/cataloguing/additem.tt modules/basket/sendbasket.tt modules/catalogue/labeledMARCdetail.tt Created attachment 70586 [details] [review] Bug 19833: Kill the "biblios" - most of the catalouging Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" modules/cataloguing/addbooks.tt modules/cataloguing/value_builder/marc21_field_008_authorities.tt modules/cataloguing/value_builder/unimarc_field_110.tt modules/cataloguing/value_builder/unimarc_field_126a.tt modules/cataloguing/value_builder/unimarc_field_140.tt Created attachment 70587 [details] [review] Bug 19833 : Changing the "biblios" - most of admin To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt Created attachment 70588 [details] [review] Bug 19833: Kill the "biblios" part 1 of the help To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". Please enter the commit message for your changes. Lines starting whoops the following files are these: (for part 1 of help) modules/help/admin/authtypes.tt modules/help/admin/biblio_framework.tt modules/help/admin/marc_subfields_structure.tt modules/help/admin/matching-rules.tt modules/help/admin/z3950servers.tt: Created attachment 70589 [details] [review] Bug 19833: Kill all the "bibilos" - help (continued) Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" and there are no typos. modules/help/members/member-flags.tt modules/help/tools/batchMod.tt modules/help/tools/export.tt modules/help/tools/letter.tt modules/help/tools/marc_modification_templates.tt modules/help/tools/stage-marc-import.tt EXTRA I have updated the "add a new subscription so that it says "bibliographic record" instead of "record" 1) go into serials --> new subscription, there should be "record" and a box to type in the record. 2) apply th patch 3) it should now say "Bibliographic Record" instead. Created attachment 70590 [details] [review] Bug 19833: Changing the "biblios" - most of reports To Test: Check the following files that all the "biblio" or "biblio record" are now written in full as "bibliographic record". modules/reports/acquisitions_stats.tt modules/reports/cash_register_status.tt modules/reports/catalogue_stats.tt modules/reports/issues_stats.tt modules/reports/reserves_stats.tt Created attachment 70591 [details] [review] Bug 19833: Changing the "biblios" acqui To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/acqui/addorderiso2709.tt:44 modules/acqui/booksellers.tt:3 modules/acqui/invoices.tt:3 Created attachment 70593 [details] [review] Bug 19833: Changing the "biblios" To Test: Check the following files that all the "biblio" or "biblio record" are now written in rull as "bibliographic record". modules/about.tt Created attachment 70594 [details] [review] Bug 19833: Kill all the "bibilos" - final couple Check the following files to see that all "biblio" or "biblio record"are changed to "bibliograhic records" and there are no typos. modules/ill/ill-requests.tt modules/installer/step3.tt Created attachment 70645 [details] [review] Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server Comment on attachment 70645 [details] [review] Bug 19986: 'Server name' doesn't appear as required Sorry wrong bug number CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt Created attachment 73041 [details] [review] Bug 19833: Kill the "biblios" 1) Check files modules/about.tt, modules/acqui/booksellers.tt and modules/acqui/invoices.tt for typos nad check that there are no "biblio" and only "biblographic record". Fixed one capitalization error during signoff. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73042 [details] [review] Bug 19833: Changing the "biblios" - most of admin To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Comment on attachment 70589 [details] [review] Bug 19833: Kill all the "bibilos" - help (continued) I'm marking this one obsolete because I think it should be rewritten. Comment on attachment 70586 [details] [review] Bug 19833: Kill the "biblios" - most of the catalouging I'm marking this one obsolete because I think it needs to be rewritten. Comment on attachment 70588 [details] [review] Bug 19833: Kill the "biblios" part 1 of the help I'm submitting a revised version of this patch. Created attachment 73044 [details] [review] Bug 19833: Changing the "biblios" - most of reports To Test: Check the following files that all the "biblio" or "biblio record" are now written in full as "bibliographic record". modules/reports/acquisitions_stats.tt modules/reports/cash_register_status.tt modules/reports/catalogue_stats.tt modules/reports/issues_stats.tt modules/reports/reserves_stats.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73045 [details] [review] Bug 19833: Changing the "biblios" acqui To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/acqui/addorderiso2709.tt:44 modules/acqui/booksellers.tt:3 modules/acqui/invoices.tt:3 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73046 [details] [review] Bug 19833: Changing the "biblios" To Test: Check the following files that all the "biblio" or "biblio record" are now written in rull as "bibliographic record". modules/about.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73048 [details] [review] Bug 19833: Kill the "biblios" 1) Check files modules/about.tt, modules/acqui/booksellers.tt and modules/acqui/invoices.tt for typos nad check that there are no "biblio" and only "biblographic record". Fixed one capitalization error during signoff. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73049 [details] [review] Bug 19833: Changing the "biblios" - most of admin To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73050 [details] [review] Bug 19833: Changing the "biblios" - most of reports To Test: Check the following files that all the "biblio" or "biblio record" are now written in full as "bibliographic record". modules/reports/acquisitions_stats.tt modules/reports/cash_register_status.tt modules/reports/catalogue_stats.tt modules/reports/issues_stats.tt modules/reports/reserves_stats.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73051 [details] [review] Bug 19833: Changing the "biblios" acqui To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/acqui/addorderiso2709.tt:44 modules/acqui/booksellers.tt:3 modules/acqui/invoices.tt:3 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73052 [details] [review] Bug 19833: Changing the "biblios" To Test: Check the following files that all the "biblio" or "biblio record" are now written in rull as "bibliographic record". modules/about.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 73053 [details] [review] Bug 19833 (follow-up) Minor corrections This patch makes minor corrections to lines modified in the previous ones. On the biblio framework page, I have deleted this line because it didn't make much sense before or after the change: "Framework name, then go to MARC biblio to set MARC editor parameters" In the web services preferences file, I reverted a change to "deletedbiblio" because it refers to a table name. I've also made corrections to instances of "biblio" in the following pages, including changing "biblio number" to "biblionumber," since it refers to a specific Koha column name. - MARC detail page - Help files: - Record matching rule;s - Batch item modification - MARC modification templates - Export data - Staged MARC record management Created attachment 78842 [details] [review] Bug 19833: Kill all the "bibilos" - final couple Check the following files to see that all "biblio" or "biblio record"are changed to "bibliograhic records" and there are no typos. modules/ill/ill-requests.tt modules/installer/step3.tt Created attachment 78843 [details] [review] Bug 19833: Kill the "biblios" 1) Check files modules/about.tt, modules/acqui/booksellers.tt and modules/acqui/invoices.tt for typos nad check that there are no "biblio" and only "biblographic record". Fixed one capitalization error during signoff. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 78844 [details] [review] Bug 19833: Changing the "biblios" - most of admin To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 78845 [details] [review] Bug 19833: Changing the "biblios" - most of reports To Test: Check the following files that all the "biblio" or "biblio record" are now written in full as "bibliographic record". modules/reports/acquisitions_stats.tt modules/reports/cash_register_status.tt modules/reports/catalogue_stats.tt modules/reports/issues_stats.tt modules/reports/reserves_stats.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 78846 [details] [review] Bug 19833: Changing the "biblios" acqui To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/acqui/addorderiso2709.tt:44 modules/acqui/booksellers.tt:3 modules/acqui/invoices.tt:3 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 78847 [details] [review] Bug 19833: Changing the "biblios" To Test: Check the following files that all the "biblio" or "biblio record" are now written in rull as "bibliographic record". modules/about.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 78848 [details] [review] Bug 19833 (follow-up) Minor corrections This patch makes minor corrections to lines modified in the previous ones. On the biblio framework page, I have deleted this line because it didn't make much sense before or after the change: "Framework name, then go to MARC biblio to set MARC editor parameters" In the web services preferences file, I reverted a change to "deletedbiblio" because it refers to a table name. I've also made corrections to instances of "biblio" in the following pages, including changing "biblio number" to "biblionumber," since it refers to a specific Koha column name. - MARC detail page - Help files: - Record matching rule;s - Batch item modification - MARC modification templates - Export data - Staged MARC record management Owen, I was not seeing the updates in the help files. Can you check this? The help files are updated, however the Help link now goes to the online version of the manual. Patch tested with a sandbox, by David Nind <david@davidnind.com> Created attachment 78929 [details] [review] Bug 19833: Kill all the "bibilos" - final couple Check the following files to see that all "biblio" or "biblio record"are changed to "bibliograhic records" and there are no typos. modules/ill/ill-requests.tt modules/installer/step3.tt Signed-off-by: David Nind <david@davidnind.com> Created attachment 78930 [details] [review] Bug 19833: Kill the "biblios" 1) Check files modules/about.tt, modules/acqui/booksellers.tt and modules/acqui/invoices.tt for typos nad check that there are no "biblio" and only "biblographic record". Fixed one capitalization error during signoff. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 78931 [details] [review] Bug 19833: Changing the "biblios" - most of admin To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 78932 [details] [review] Bug 19833: Changing the "biblios" - most of reports To Test: Check the following files that all the "biblio" or "biblio record" are now written in full as "bibliographic record". modules/reports/acquisitions_stats.tt modules/reports/cash_register_status.tt modules/reports/catalogue_stats.tt modules/reports/issues_stats.tt modules/reports/reserves_stats.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 78933 [details] [review] Bug 19833: Changing the "biblios" acqui To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/acqui/addorderiso2709.tt:44 modules/acqui/booksellers.tt:3 modules/acqui/invoices.tt:3 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 78934 [details] [review] Bug 19833: Changing the "biblios" To Test: Check the following files that all the "biblio" or "biblio record" are now written in rull as "bibliographic record". modules/about.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 78935 [details] [review] Bug 19833 (follow-up) Minor corrections This patch makes minor corrections to lines modified in the previous ones. On the biblio framework page, I have deleted this line because it didn't make much sense before or after the change: "Framework name, then go to MARC biblio to set MARC editor parameters" In the web services preferences file, I reverted a change to "deletedbiblio" because it refers to a table name. I've also made corrections to instances of "biblio" in the following pages, including changing "biblio number" to "biblionumber," since it refers to a specific Koha column name. - MARC detail page - Help files: - Record matching rule;s - Batch item modification - MARC modification templates - Export data - Staged MARC record management Signed-off-by: David Nind <david@davidnind.com> Created attachment 78944 [details] [review] Bug 19833: Kill all the "bibilos" - final couple Check the following files to see that all "biblio" or "biblio record"are changed to "bibliograhic records" and there are no typos. modules/ill/ill-requests.tt modules/installer/step3.tt Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78945 [details] [review] Bug 19833: Kill the "biblios" 1) Check files modules/about.tt, modules/acqui/booksellers.tt and modules/acqui/invoices.tt for typos nad check that there are no "biblio" and only "biblographic record". Fixed one capitalization error during signoff. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78946 [details] [review] Bug 19833: Changing the "biblios" - most of admin To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78947 [details] [review] Bug 19833: Changing the "biblios" - most of reports To Test: Check the following files that all the "biblio" or "biblio record" are now written in full as "bibliographic record". modules/reports/acquisitions_stats.tt modules/reports/cash_register_status.tt modules/reports/catalogue_stats.tt modules/reports/issues_stats.tt modules/reports/reserves_stats.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78948 [details] [review] Bug 19833: Changing the "biblios" acqui To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/acqui/addorderiso2709.tt:44 modules/acqui/booksellers.tt:3 modules/acqui/invoices.tt:3 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78949 [details] [review] Bug 19833: Changing the "biblios" To Test: Check the following files that all the "biblio" or "biblio record" are now written in rull as "bibliographic record". modules/about.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78950 [details] [review] Bug 19833: (follow-up) Minor corrections This patch makes minor corrections to lines modified in the previous ones. On the biblio framework page, I have deleted this line because it didn't make much sense before or after the change: "Framework name, then go to MARC biblio to set MARC editor parameters" In the web services preferences file, I reverted a change to "deletedbiblio" because it refers to a table name. I've also made corrections to instances of "biblio" in the following pages, including changing "biblio number" to "biblionumber," since it refers to a specific Koha column name. - MARC detail page - Help files: - Record matching rule;s - Batch item modification - MARC modification templates - Export data - Staged MARC record management Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78951 [details] [review] Bug 19833: Bibliographic Record => Bibliographic record Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |