Summary: | Add multiple patrons to a list by cardnumber | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | george, kyle, nick, sally.healey |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19837 - Add multiple patrons to a list by barcode
Bug 19837 - Add error feedback for duplicatred or unfound cardnumbers Bug 19837 - Add multiple patrons to a list by barcode Bug 19837 - Add error feedback for duplicatred or unfound cardnumbers Bug 19837: Add multiple patrons to a list by barcode Bug 19837: Add error feedback for duplicated or unfound cardnumbers |
Description
Owen Leonard
2017-12-19 15:13:31 UTC
Created attachment 69913 [details] [review] Bug 19837 - Add multiple patrons to a list by barcode This patch adds the interface change and basic functionality for an option to add multiple patrons to a patron list by scanning barcodes. To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary, and got to the "Add patrons" screen. - Test the process for adding patrons using the "Patron search" text input. - Test the process for adding patrons using the "Enter multiple card numbers" option. This should really have some error-handling added to it: Onscreen messages when a non-existing patron card number is submitted or when a patron already exists on the list. *** Bug 19525 has been marked as a duplicate of this bug. *** Created attachment 70240 [details] [review] Bug 19837 - Add error feedback for duplicatred or unfound cardnumbers To test: 1 - Enter some patrons on a list 2 - 'Enter multiple cardnumbers' 3 - Make sure to add some that are already in list, some that don't exist, and some new patrons 4 - Verify results are as expected with warnings I added some error feedback, it could certainly be made prettier, take a look please Owen? Ideally we would be able to add by borrowernumber as well, but I think that is for another bug Thanks Nick! I think it looks fine. Created attachment 70277 [details] [review] Bug 19837 - Add multiple patrons to a list by barcode This patch adds the interface change and basic functionality for an option to add multiple patrons to a patron list by scanning barcodes. To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary, and got to the "Add patrons" screen. - Test the process for adding patrons using the "Patron search" text input. - Test the process for adding patrons using the "Enter multiple card numbers" option. This should really have some error-handling added to it: Onscreen messages when a non-existing patron card number is submitted or when a patron already exists on the list. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 70278 [details] [review] Bug 19837 - Add error feedback for duplicatred or unfound cardnumbers To test: 1 - Enter some patrons on a list 2 - 'Enter multiple cardnumbers' 3 - Make sure to add some that are already in list, some that don't exist, and some new patrons 4 - Verify results are as expected with warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 71910 [details] [review] Bug 19837: Add multiple patrons to a list by barcode This patch adds the interface change and basic functionality for an option to add multiple patrons to a patron list by scanning barcodes. To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary, and got to the "Add patrons" screen. - Test the process for adding patrons using the "Patron search" text input. - Test the process for adding patrons using the "Enter multiple card numbers" option. This should really have some error-handling added to it: Onscreen messages when a non-existing patron card number is submitted or when a patron already exists on the list. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 71911 [details] [review] Bug 19837: Add error feedback for duplicated or unfound cardnumbers To test: 1 - Enter some patrons on a list 2 - 'Enter multiple cardnumbers' 3 - Make sure to add some that are already in list, some that don't exist, and some new patrons 4 - Verify results are as expected with warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Enhancement, not backported for 17.11 |