Bug 19840

Summary: Patron note is not displayed on checkin
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, josef.moravec, kyle.m.hall, nick
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14224, 18276    
Bug Blocks:    
Attachments: Bug 19840: Fix - display patron note on checkin
Bug 19840: And avoid XSS...
Bug 19840: Fix - display patron note on checkin
Bug 19840: And avoid XSS...
Bug 19840: Fix - display patron note on checkin
Bug 19840: And avoid XSS...

Description Jonathan Druart 2017-12-19 18:42:33 UTC
If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in
Comment 1 Jonathan Druart 2017-12-19 18:43:42 UTC
This bug may have been caused by
  commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
    Bug 18276: Remove GetBiblioFromItemNumber - Easy ones
Comment 2 Jonathan Druart 2017-12-19 18:49:34 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2017-12-19 18:49:38 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2017-12-21 15:19:36 UTC
Created attachment 70054 [details] [review]
Bug 19840: Fix - display patron note on checkin

If a patron let a note on the checkout (AllowCheckoutNotes), it is
supposed to be displayed when checked in.

Test plan:
1/ Enable AllowCheckoutNotes
2/ Check an item out
3/ At the opac let a note on the checkout
4/ Check the item in
   => With this patch applied you should see the notes displayed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2017-12-21 15:19:39 UTC
Created attachment 70055 [details] [review]
Bug 19840: And avoid XSS...

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Josef Moravec 2017-12-21 21:35:49 UTC
Created attachment 70088 [details] [review]
Bug 19840: Fix - display patron note on checkin

If a patron let a note on the checkout (AllowCheckoutNotes), it is
supposed to be displayed when checked in.

Test plan:
1/ Enable AllowCheckoutNotes
2/ Check an item out
3/ At the opac let a note on the checkout
4/ Check the item in
   => With this patch applied you should see the notes displayed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Josef Moravec 2017-12-21 21:35:54 UTC
Created attachment 70089 [details] [review]
Bug 19840: And avoid XSS...

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 8 Jonathan Druart 2017-12-22 16:17:42 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 9 Nick Clemens 2018-01-15 16:45:16 UTC
Awesome work all, pushed to stable for 17.11.02
Comment 10 Fridolin Somers 2018-01-19 12:52:07 UTC
Bug 18276 is not in 17.05.x but is this bug needed for it anyway ?