Summary: | Patron note is not displayed on checkin | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, josef.moravec, kyle.m.hall, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14224, 18276 | ||
Bug Blocks: | |||
Attachments: |
Bug 19840: Fix - display patron note on checkin
Bug 19840: And avoid XSS... Bug 19840: Fix - display patron note on checkin Bug 19840: And avoid XSS... Bug 19840: Fix - display patron note on checkin Bug 19840: And avoid XSS... |
Description
Jonathan Druart
2017-12-19 18:42:33 UTC
This bug may have been caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Created attachment 69923 [details] [review] Bug 19840: Fix - display patron note on checkin If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in. Test plan: 1/ Enable AllowCheckoutNotes 2/ Check an item out 3/ At the opac let a note on the checkout 4/ Check the item in => With this patch applied you should see the notes displayed Created attachment 69924 [details] [review] Bug 19840: And avoid XSS... Created attachment 70054 [details] [review] Bug 19840: Fix - display patron note on checkin If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in. Test plan: 1/ Enable AllowCheckoutNotes 2/ Check an item out 3/ At the opac let a note on the checkout 4/ Check the item in => With this patch applied you should see the notes displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 70055 [details] [review] Bug 19840: And avoid XSS... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 70088 [details] [review] Bug 19840: Fix - display patron note on checkin If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in. Test plan: 1/ Enable AllowCheckoutNotes 2/ Check an item out 3/ At the opac let a note on the checkout 4/ Check the item in => With this patch applied you should see the notes displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 70089 [details] [review] Bug 19840: And avoid XSS... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.02 Bug 18276 is not in 17.05.x but is this bug needed for it anyway ? |