| Summary: | Move template JavaScript to the footer: UNIMARC editor plugins, part 1 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, mtompset, nick, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19968 | ||
| Bug Blocks: | 17858, 19868 | ||
| Attachments: |
Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1
Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 |
||
|
Description
Owen Leonard
2017-12-21 17:14:37 UTC
Created attachment 70069 [details] [review] Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 This patch updates several UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_100.tt - unimarc_field_100_authorities.tt - unimarc_field_105.tt - unimarc_field_106.tt - unimarc_field_110.tt - unimarc_field_115a.tt - unimarc_field_115b.tt Here's a more thorough description of how this patch can be tested even if you don't have a UNIMARC system: - Go to Administration -> MARC frameworks -> Default framework -> MARC structure - For any tag (I like to use 000 because it's the first one), choose Actions -> Subfields. - Edit any subfield you want to configure (choose one that isn't hidden). - Expand the "Other options" panel and select the plugin you want to test under "Plugin." - Save changes. - Open an existing or new MARC record for editing in the standard MARC editor. - Find the tag and subfield you just modified, and look for the small plugin trigger icon next to the form field. - Confirm that clicking this link triggers the correct plugin (the pop-up window should have a heading with the correct plugin name). - Make some changes to the options in the plugin window in a way that you will be able to confirm the changes are transferred to the field in the MARC editor. For instance, choose all the same codes for multiple fields. - Submit your changes in the plugin's pop-up window. The window should close. - Confirm that the values you submitted from the plugin window have been transferred to the correct field in the MARC editor. Created attachment 72631 [details] [review] Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 This patch updates several UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_100.tt - unimarc_field_100_authorities.tt - unimarc_field_105.tt - unimarc_field_106.tt - unimarc_field_110.tt - unimarc_field_115a.tt - unimarc_field_115b.tt Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> The pop-up for unimarc_field_106.pl is not sized right, but it's the same without the patch. Created attachment 73248 [details] [review] Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 This patch updates several UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_100.tt - unimarc_field_100_authorities.tt - unimarc_field_105.tt - unimarc_field_106.tt - unimarc_field_110.tt - unimarc_field_115a.tt - unimarc_field_115b.tt Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, enhancement, not backported for stable |