Summary: | Move template JavaScript to the footer: UNIMARC editor plugins, part 7 | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | anne-claire.bernaudin, jonathan.druart, nick, olivier.roure, sandboxes, testopia, victor |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19877 | ||
Bug Blocks: | 17858, 19952 | ||
Attachments: |
Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7
Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 |
Description
Owen Leonard
2017-12-22 18:04:13 UTC
Created attachment 70229 [details] [review] Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt There is a problem with 4XX fields On the pop-up window the link choose do nothing on click. The others fields are ok. Created attachment 72870 [details] [review] Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt Ok for 4XX Ok for 210c_bis, ok for 225a_bis but KO for 210c and 225a (drop down menu is empty) all others fields works as expected KO for 210c : search retrieves no result (In reply to Olivier from comment #4) > but KO for 210c and 225a I think this may be due to insufficient authorities data? Does it work any differently in master? Thanks for testing! According to Olivier: It does the same on master. He will sign it off Patch tested with a sandbox, by Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Not due to insufficient authorities data. The problem is the same on Master. Created attachment 72946 [details] [review] Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Created attachment 73254 [details] [review] Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, enhancement, not backported for stable |