| Summary: | Embedded HTML5 videos are broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, george, kelly, nick, sandboxes |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 18754 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 19913: Fix embedded HTML5 videos at the OPAC
Bug 19913: Fix embedded HTML5 videos at the OPAC Bug 19913: Fix embedded HTML5 videos at the OPAC |
||
Created attachment 70255 [details] [review] Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet Patch tested with a sandbox, by George <george@nekls.org> Created attachment 70333 [details] [review] Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet Signed-off-by: George <george@nekls.org> Created attachment 70334 [details] [review] Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet Signed-off-by: George <george@nekls.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> (In reply to sandboxes@biblibre.com from comment #2) > Patch tested with a sandbox, by George <george@nekls.org> George, I have modified your signed-off-by line to add your surname. I hope it is ok with you. Pushed to master for 18.05, thanks to everybody involved! (In reply to Jonathan Druart from comment #5) > (In reply to sandboxes@biblibre.com from comment #2) > > Patch tested with a sandbox, by George <george@nekls.org> > > George, I have modified your signed-off-by line to add your surname. I hope > it is ok with you. Jonathan - not a problem. Awesome work all, pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 |
The video element is badly generated. Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt