Bug 19995

Summary: use Modern::Perl in Catalogue perl scripts
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Architecture, internals, and plumbingAssignee: Zoe Bennett <zoebennett1308>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, katrin.fischer, nick
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 2505, 20539, 20620    
Attachments: Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'
Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'
Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'
Bug 19995: use Modern::Perl in Catalogue perl scripts

Description Aleisha Amohia 2018-01-17 04:38:45 UTC
use Modern::Perl should be used instead of use strict; use warnings;

Relevant in:
MARCdetail.pl
export.pl
image.pl
imageviewer.pl
issuehistory.pl
labeledMARCdetail.pl
moredetail.pl
search.pl
showmarc.pl
updateitem.pl
Comment 1 Zoe Bennett 2018-01-18 00:48:35 UTC
Created attachment 70656 [details] [review]
Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'

Test Plan:
- Check that it now says 'use Modern::Perl;' and not 'use strict; use
warnings;' in the following catalogue perl scripts.

MARCdetail.pl
export.pl
image.pl
imageviewer.pl
issuehistory.pl
labeledMARCdetail.pl
moredetail.pl
search.pl
showmarc.pl
updateitem.pl
Comment 2 Jon Knight 2018-01-24 18:09:43 UTC
Created attachment 70883 [details] [review]
Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'

Test Plan:
- Check that it now says 'use Modern::Perl;' and not 'use strict; use
warnings;' in the following catalogue perl scripts.

MARCdetail.pl
export.pl
image.pl
imageviewer.pl
issuehistory.pl
labeledMARCdetail.pl
moredetail.pl
search.pl
showmarc.pl
updateitem.pl
Comment 3 Jon Knight 2018-01-24 18:37:29 UTC
Created attachment 70895 [details] [review]
Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;'

Test Plan:
- Check that it now says 'use Modern::Perl;' and not 'use strict; use
warnings;' in the following catalogue perl scripts.

MARCdetail.pl
export.pl
image.pl
imageviewer.pl
issuehistory.pl
labeledMARCdetail.pl
moredetail.pl
search.pl
showmarc.pl
updateitem.pl

Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Comment 4 Katrin Fischer 2018-02-04 14:41:34 UTC
Created attachment 71197 [details] [review]
Bug 19995: use Modern::Perl in Catalogue perl scripts

Test Plan:
- Check that it now says 'use Modern::Perl;' and not 'use strict; use
warnings;' in the following catalogue perl scripts.

MARCdetail.pl
export.pl
image.pl
imageviewer.pl
issuehistory.pl
labeledMARCdetail.pl
moredetail.pl
search.pl
showmarc.pl
updateitem.pl

Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2018-02-05 12:58:49 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2018-02-16 00:57:23 UTC
Awesome work all! Enhancement not backported to stable.