| Summary: | Remove forbidden patterns from .inc and .tt files | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Indranil Das Gupta <indradg> |
| Component: | Templates | Assignee: | Indranil Das Gupta <indradg> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | mtompset |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 20053 | ||
| Bug Blocks: | |||
| Attachments: | Bug 20066 - Remove forbidden patterns from .inc and .tt files | ||
|
Description
Indranil Das Gupta
2018-01-22 19:32:08 UTC
Created attachment 70810 [details] [review] Bug 20066 - Remove forbidden patterns from .inc and .tt files This patch removes the forbidden patterns from the following files: a) datatables.inc => [% interface %] instead of [% themelang %] b) opac-auth-MARCdetail.tt => hard-coded path to JS resource. c) opac-auth-detail.tt => hard-coded path to JS resource. Test plan ========= 1/ Apply the patch from Bug 20053 and run koha-qa.pl. The QA tool will throw up these 3 files as FAIL for forbidden patterns use. 2/ Now apply this patch and run koha-qa.pl. The result should now be OK. Bug 20053 removed the javascript type, and yet, this keeps it. It does not apply in any order. Please fix. |