Bug 20066

Summary: Remove forbidden patterns from .inc and .tt files
Product: Koha Reporter: Indranil Das Gupta <indradg>
Component: TemplatesAssignee: Indranil Das Gupta <indradg>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: mtompset
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20053    
Bug Blocks:    
Attachments: Bug 20066 - Remove forbidden patterns from .inc and .tt files

Description Indranil Das Gupta 2018-01-22 19:32:08 UTC
The following files contain forbidden patterns

a) includes/datatables.inc => [% interface %] instead of [% themelang %]

b) modules/opac-auth-MARCdetail.tt => hard-coded path

c) modules/opac-auth-detail.tt => hard-coded path

This patch removes these.
Comment 1 Indranil Das Gupta 2018-01-22 19:50:59 UTC
Created attachment 70810 [details] [review]
Bug 20066 - Remove forbidden patterns from .inc and .tt files

This patch removes the forbidden patterns from the following files:

a) datatables.inc => [% interface %] instead of [% themelang %]

b) opac-auth-MARCdetail.tt => hard-coded path to JS resource.

c) opac-auth-detail.tt => hard-coded path to JS resource.

Test plan
=========

1/ Apply the patch from Bug 20053 and run koha-qa.pl. The QA tool
   will throw up these 3 files as FAIL for forbidden patterns use.

2/ Now apply this patch and run koha-qa.pl. The result should now
   be OK.
Comment 2 M. Tompsett 2018-01-26 03:35:57 UTC
Bug 20053 removed the javascript type, and yet, this keeps it. It does not apply in any order. Please fix.
Comment 3 M. Tompsett 2018-09-06 18:23:18 UTC
While not really a duplicate, the Asset.pm template plugin basically corrected this issue intrinsically.

*** This bug has been marked as a duplicate of bug 20538 ***