The following files contain forbidden patterns a) includes/datatables.inc => [% interface %] instead of [% themelang %] b) modules/opac-auth-MARCdetail.tt => hard-coded path c) modules/opac-auth-detail.tt => hard-coded path This patch removes these.
Created attachment 70810 [details] [review] Bug 20066 - Remove forbidden patterns from .inc and .tt files This patch removes the forbidden patterns from the following files: a) datatables.inc => [% interface %] instead of [% themelang %] b) opac-auth-MARCdetail.tt => hard-coded path to JS resource. c) opac-auth-detail.tt => hard-coded path to JS resource. Test plan ========= 1/ Apply the patch from Bug 20053 and run koha-qa.pl. The QA tool will throw up these 3 files as FAIL for forbidden patterns use. 2/ Now apply this patch and run koha-qa.pl. The result should now be OK.
Bug 20053 removed the javascript type, and yet, this keeps it. It does not apply in any order. Please fix.
While not really a duplicate, the Asset.pm template plugin basically corrected this issue intrinsically. *** This bug has been marked as a duplicate of bug 20538 ***