Summary: | Item search should honor syspref 'delimiter' | ||
---|---|---|---|
Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
Component: | OPAC | Assignee: | Olivia <olivialokm> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, david, katrin.fischer, liav |
Version: | master | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17031 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 20171: Fixed CSV output to use syspref 'delimiter' in export files
Bug 20171: Fixed CSV output to use syspref 'delimiter' in export files |
Description
Victor Grousset/tuxayo
2018-02-09 17:40:23 UTC
Sorry, won't have the time to work on this (there will be always more problematic stuff for me to fix). But it's a reasonably low hanging fruit/beginner friendly bug and I'll be glad to provide advice if needed. Created attachment 84169 [details] [review] Bug 20171: Fixed CSV output to use syspref 'delimiter' in export files To Find Fix: 1. Go to sysprefs and change delimiter to slashes 2. Under the Search drop down click Item search 3. Set Output as CSV 4. Click Search 5. A file should be downloaded and when opened the set delimiter should appear as the delimiter Created attachment 84216 [details] [review] Bug 20171: Fixed CSV output to use syspref 'delimiter' in export files To Find Fix: 1. Go to sysprefs and change delimiter to slashes 2. Under the Search drop down click Item search 3. Set Output as CSV 4. Click Search 5. A file should be downloaded and when opened the set delimiter should appear as the delimiter Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> Signed-off by Mikaël, but status not changed. So have updated. Also changed assignee to Olivia. (Can confirm the patch works as expected). Hi all, I tested, but found 2 issues that we need to fix: - The QA script complains about missing filters - While most values of the system preference translate directly, tabulation does not: ;|tabulation|,|/|\|#||. So when tab is selected, the file exported is not usable as it has "tabulation" printed as a separator instead of the actual 'tab'. I believe this is already fixed in master. Setting to resolved |