Bug 20187

Summary: New rewrite rules can break custom css
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, m.de.rooy, victor
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 12904    
Bug Blocks: 20259    
Attachments: Bug 20187: New rewrite rules can break custom css
Bug 20187: New rewrite rules can break custom css
Bug 20187: Add another KOHA_VERSION in C4/Auth
Bug 20187: Add another KOHA_VERSION in C4/Auth
Bug 20187: New rewrite rules can break custom css
Bug 20187: (QA follow-up) Replace N,L flag by L flag
Bug 20187: Fix Tiny MCE
Bug 20187: (QA follow-up) Replace N,L flag by L flag

Description Kyle M Hall 2018-02-13 13:20:07 UTC
Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404.

We should make the rewrite rules as specific as possible for the format we are using.
Comment 1 Kyle M Hall 2018-02-13 13:24:04 UTC
Created attachment 71537 [details] [review]
Bug 20187: New rewrite rules can break custom css

Koha has the ability to include custom css in the apache configuration.
If a library has any custom css ( or adds a custom js file in some way ),
and that file has an underscore in it ( e.g. my_custom.css ), the
apache rewrite rule will convert it to my.css and thus it will 404.

We should make the rewrite rules as specific as possible for the
format we are using.

Test Plan:
1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it
2) Note it does not work
3) Apply this patch
4) Update the apache rewrite rules to match those in the patch
   For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl
5) Restart apache
6) Reload the page, your custom css should load now!
Comment 2 Victor Grousset/tuxayo 2018-02-13 13:46:44 UTC
Created attachment 71538 [details] [review]
Bug 20187: New rewrite rules can break custom css

Koha has the ability to include custom css in the apache configuration.
If a library has any custom css ( or adds a custom js file in some way ),
and that file has an underscore in it ( e.g. my_custom.css ), the
apache rewrite rule will convert it to my.css and thus it will 404.

We should make the rewrite rules as specific as possible for the
format we are using.

Test Plan:
1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it
2) Note it does not work
3) Apply this patch
4) Update the apache rewrite rules to match those in the patch
   For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl
5) Restart apache
6) Reload the page, your custom css should load now!

Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
Comment 3 Marcel de Rooy 2018-02-13 14:26:15 UTC
Intranet login fails
Comment 4 Victor Grousset/tuxayo 2018-02-13 14:30:54 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2018-02-13 14:42:56 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2018-02-13 14:48:24 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2018-02-13 14:52:16 UTC
(In reply to Marcel de Rooy from comment #6)
> Created attachment 71542 [details] [review] [review]
> Bug 20187: Add another KOHA_VERSION in C4/Auth
> 
> Needed when logging out and in again..
> 
> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Moved to bug 20189
Comment 8 Marcel de Rooy 2018-02-13 14:56:58 UTC
Created attachment 71544 [details] [review]
Bug 20187: New rewrite rules can break custom css

Koha has the ability to include custom css in the apache configuration.
If a library has any custom css ( or adds a custom js file in some way ),
and that file has an underscore in it ( e.g. my_custom.css ), the
apache rewrite rule will convert it to my.css and thus it will 404.

We should make the rewrite rules as specific as possible for the
format we are using.

Test Plan:
1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it
2) Note it does not work
3) Apply this patch
4) Update the apache rewrite rules to match those in the patch
   For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl
5) Restart apache
6) Reload the page, your custom css should load now!

Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2018-02-13 14:57:02 UTC
Created attachment 71545 [details] [review]
Bug 20187: (QA follow-up) Replace N,L flag by L flag

The flags [N,L] make no sense: next and last combined.
Choosing here for L to stop the rewriting process.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Kyle M Hall 2018-02-13 15:01:22 UTC Comment hidden (obsolete)
Comment 11 Victor Grousset/tuxayo 2018-02-13 15:44:08 UTC
Created attachment 71554 [details] [review]
Bug 20187: (QA follow-up) Replace N,L flag by L flag

The flags [N,L] make no sense: next and last combined.
Choosing here for L to stop the rewriting process.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
Comment 12 Jonathan Druart 2018-02-13 16:00:51 UTC
Pushed to master for 18.05, thanks to everybody involved!