Description
Kyle M Hall (khall)
2018-02-13 13:20:07 UTC
Created attachment 71537 [details] [review] Bug 20187: New rewrite rules can break custom css Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. Test Plan: 1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it 2) Note it does not work 3) Apply this patch 4) Update the apache rewrite rules to match those in the patch For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl 5) Restart apache 6) Reload the page, your custom css should load now! Created attachment 71538 [details] [review] Bug 20187: New rewrite rules can break custom css Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. Test Plan: 1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it 2) Note it does not work 3) Apply this patch 4) Update the apache rewrite rules to match those in the patch For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl 5) Restart apache 6) Reload the page, your custom css should load now! Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Intranet login fails Intranet login works for me, do you have more details? Created attachment 71541 [details] [review] Bug 20187: Add another KOHA_VERSION in C4/Auth Needed when logging out and in again.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 71542 [details] [review] Bug 20187: Add another KOHA_VERSION in C4/Auth Needed when logging out and in again.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #6) > Created attachment 71542 [details] [review] [review] > Bug 20187: Add another KOHA_VERSION in C4/Auth > > Needed when logging out and in again.. > > Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Moved to bug 20189 Created attachment 71544 [details] [review] Bug 20187: New rewrite rules can break custom css Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. Test Plan: 1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it 2) Note it does not work 3) Apply this patch 4) Update the apache rewrite rules to match those in the patch For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl 5) Restart apache 6) Reload the page, your custom css should load now! Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 71545 [details] [review] Bug 20187: (QA follow-up) Replace N,L flag by L flag The flags [N,L] make no sense: next and last combined. Choosing here for L to stop the rewriting process. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 71547 [details] [review] Bug 20187: Fix Tiny MCE Created attachment 71554 [details] [review] Bug 20187: (QA follow-up) Replace N,L flag by L flag The flags [N,L] make no sense: next and last combined. Choosing here for L to stop the rewriting process. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Pushed to master for 18.05, thanks to everybody involved! |