Bug 20214

Summary: Patron search is broken
Product: Koha Reporter: Victor Grousset/tuxayo <victor>
Component: PatronsAssignee: Victor Grousset/tuxayo <victor>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: gmcharlt, jonathan.druart, julian.maurice, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18403    
Bug Blocks:    
Attachments: Bug 20214: Fix patron search: remove newline breaking JSON
Bug 20214: Fix patron search: remove newline breaking JSON
Bug 20214: Fix patron search: remove newline breaking JSON

Description Victor Grousset/tuxayo 2018-02-15 15:04:41 UTC
== Reproduce ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"

== Cause ==
Newline breaks JSON

Bug 18403
https://gitlab.com/koha-community/Koha/commit/5f80977875ff124d411f2cd89de4a944fa9c27af#011cc854828acd91857475b182f8c8ba3b274e4c_12_30


== Fix ==
[% IF data.title %]
↓
[%- IF data.title %]
Comment 1 Victor Grousset/tuxayo 2018-02-15 15:08:36 UTC
Created attachment 71662 [details] [review]
Bug 20214: Fix patron search: remove newline breaking JSON

== Test plan ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"
3. result never display
4. apply patch
5. search "a"
3. result display
Comment 2 Owen Leonard 2018-02-15 15:14:02 UTC
Created attachment 71663 [details] [review]
Bug 20214: Fix patron search: remove newline breaking JSON

== Test plan ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"
3. result never display
4. apply patch
5. search "a"
3. result display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Julian Maurice 2018-02-15 15:17:47 UTC
Created attachment 71664 [details] [review]
Bug 20214: Fix patron search: remove newline breaking JSON

== Test plan ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"
3. result never display
4. apply patch
5. search "a"
3. result display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Jonathan Druart 2018-02-15 15:44:54 UTC
Pushed to master for 18.05, thanks to everybody involved!