Bug 20214 - Patron search is broken
Summary: Patron search is broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low blocker (vote)
Assignee: Victor Grousset/tuxayo
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 18403
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-15 15:04 UTC by Victor Grousset/tuxayo
Modified: 2018-06-04 20:15 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20214: Fix patron search: remove newline breaking JSON (1.05 KB, patch)
2018-02-15 15:08 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 20214: Fix patron search: remove newline breaking JSON (1.10 KB, patch)
2018-02-15 15:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20214: Fix patron search: remove newline breaking JSON (1.16 KB, patch)
2018-02-15 15:17 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2018-02-15 15:04:41 UTC
== Reproduce ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"

== Cause ==
Newline breaks JSON

Bug 18403
https://gitlab.com/koha-community/Koha/commit/5f80977875ff124d411f2cd89de4a944fa9c27af#011cc854828acd91857475b182f8c8ba3b274e4c_12_30


== Fix ==
[% IF data.title %]
↓
[%- IF data.title %]
Comment 1 Victor Grousset/tuxayo 2018-02-15 15:08:36 UTC
Created attachment 71662 [details] [review]
Bug 20214: Fix patron search: remove newline breaking JSON

== Test plan ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"
3. result never display
4. apply patch
5. search "a"
3. result display
Comment 2 Owen Leonard 2018-02-15 15:14:02 UTC
Created attachment 71663 [details] [review]
Bug 20214: Fix patron search: remove newline breaking JSON

== Test plan ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"
3. result never display
4. apply patch
5. search "a"
3. result display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Julian Maurice 2018-02-15 15:17:47 UTC
Created attachment 71664 [details] [review]
Bug 20214: Fix patron search: remove newline breaking JSON

== Test plan ==
1. go/cgi-bin/koha/members/members-home.pl
2. search "a"
3. result never display
4. apply patch
5. search "a"
3. result display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Jonathan Druart 2018-02-15 15:44:54 UTC
Pushed to master for 18.05, thanks to everybody involved!