| Summary: | Regression - SIP checkout broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
| Component: | SIP2 | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | colin.campbell, jonathan.druart, josef.moravec, m.de.rooy, mtj, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19280 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 20251: (bug 19280 follow-up) FIX SIP checkout
Patch with signoff Bug 20251: (bug 19280 follow-up) FIX SIP checkout |
||
Caused by
commit d8dc86bc4bde4b5744cd0bc954e1e5767250dde2
Bug 19280: Pass a Koha::Patron to CanBookBeIssued
Created attachment 72291 [details] [review] Bug 20251: (bug 19280 follow-up) FIX SIP checkout Hi Colin, thanks for catching that! Does this patch make sense to you? Created attachment 72308 [details] [review] Patch with signoff (In reply to Jonathan Druart from comment #3) > Hi Colin, thanks for catching that! > Does this patch make sense to you? Yes, I've ran tests doing issues and related operations and responses are ok QA: Looking here now Created attachment 72343 [details] [review] Bug 20251: (bug 19280 follow-up) FIX SIP checkout Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.05, thanks to all for your hard work. Dependency not in stable. |
Attempts to checkout via sip cause the sipserver to crash. The interface to CanBookBeIssued was altered so it now requires a Koha::Patron object. When passed an oldstyle Patron hash it aborts on the call to unblessed. Can be mitigated by retrieving a Patron object with Koha::Patrons->find( { cardnumber => $borrower->{cardnumber}} ); in _can_we_issue sub of Checkout.pm but it may be time to look at rationalizing the patron handling in the SIP routines