| Summary: | Unify MARC21 ISBN/ISSN handling in XSLT in the staff interface | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | Staff interface | Assignee: | paxed <pasi.kallinen> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, martin.renvoize, nick, sandboxes |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 28984 | ||
| Attachments: |
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL |
||
|
Description
paxed
2018-03-06 10:20:23 UTC
Created attachment 72467 [details] [review] Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead. Test plan: 1) Apply patch 2) Search for any records, check that the ISBN and ISSN are shown correctly 3) Go to biblio detail pages, check that the ISBN and ISSN are shown correctly Patch tested with a sandbox, by claude <claude.brayer@cea.fr> Created attachment 72683 [details] [review] Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead. Test plan: 1) Apply patch 2) Search for any records, check that the ISBN and ISSN are shown correctly 3) Go to biblio detail pages, check that the ISBN and ISSN are shown correctly Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: claude <claude.brayer@cea.fr> Created attachment 75847 [details] [review] Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead. Test plan: 1) Apply patch 2) Search for any records, check that the ISBN and ISSN are shown correctly 3) Go to biblio detail pages, check that the ISBN and ISSN are shown correctly Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: claude <claude.brayer@cea.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looks solid and works as expected.. always nice to dry out some code a little :) Awesome work all! Pushed to master for 18.11.x Enhancement, not backporting for 18.05.x series. |