Bug 20339 - Unify MARC21 ISBN/ISSN handling in XSL
Summary: Unify MARC21 ISBN/ISSN handling in XSL
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-06 10:20 UTC by paxed
Modified: 2018-03-12 13:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL (6.50 KB, patch)
2018-03-06 10:23 UTC, paxed
Details | Diff | Splinter Review
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL (6.53 KB, patch)
2018-03-12 13:22 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2018-03-06 10:20:23 UTC
The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead.
Comment 1 paxed 2018-03-06 10:23:52 UTC
Created attachment 72467 [details] [review]
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL

The code to show the ISBN and ISSN is repeated between the search results
and the detail view. Create a function to show the ISBN/ISSN, and call
that instead.

Test plan:
1) Apply patch
2) Search for any records, check that the ISBN and ISSN are shown
   correctly
3) Go to biblio detail pages, check that the ISBN and ISSN are shown
   correctly
Comment 2 sandboxes@biblibre.com 2018-03-12 13:22:10 UTC
Patch tested with a sandbox, by claude <claude.brayer@cea.fr>
Comment 3 sandboxes@biblibre.com 2018-03-12 13:22:32 UTC
Created attachment 72683 [details] [review]
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL

The code to show the ISBN and ISSN is repeated between the search results
and the detail view. Create a function to show the ISBN/ISSN, and call
that instead.

Test plan:
1) Apply patch
2) Search for any records, check that the ISBN and ISSN are shown
   correctly
3) Go to biblio detail pages, check that the ISBN and ISSN are shown
   correctly

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: claude <claude.brayer@cea.fr>