Bug 20392

Summary: Multiple biblio holding does not work when patron is not set
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: Hold requestsAssignee: Josef Moravec <josef.moravec>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle, maksim.sen, sandboxes
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20392: Fix handling multi hold when not patron set
Bug 20392: Fix handling multi hold when not patron set
Bug 20392: Fix handling multi hold when not patron set
Bug 20392: Fix handling multi hold when not patron set

Description Josef Moravec 2018-03-13 20:02:57 UTC
To recreate:

1) Set the system preference DisplayMultiPlaceHold to enable
2) Search in staff client catalogue
3) On results page check more then one result and click on Place hold button at the top of the page
4) Search for patron, but don't be to specific, you need to have more then one result
5) Click on one of the found patron
6) Now you are going to confirm a hold, but only for one record!
Comment 1 Josef Moravec 2018-03-13 20:09:27 UTC
Created attachment 72814 [details] [review]
Bug 20392: Fix handling multi hold when not patron set

Test plan:
0) Do not apply the patch
1) Set the system preference DisplayMultiPlaceHold to enable
2) Search in staff client catalogue
3) On results page check more then one result and click on Place hold
button at the top of the page
4) Search for patron, but don't be to specific, you need to have more
then one result
5) Click on one of the found patron
6) Now you are going to confirm a hold, but only for one record!
7) Apply the patch
8) Repeat 2-5 and confirm that now it is working as expected ( place
    hold for multiple records)
Comment 2 Biblibre Sandboxes 2018-03-14 13:04:11 UTC
Patch tested with a sandbox, by delaye <stephane.delaye@biblibre.com>
Comment 3 Biblibre Sandboxes 2018-03-14 13:04:32 UTC
Created attachment 72856 [details] [review]
Bug 20392: Fix handling multi hold when not patron set

Test plan:
0) Do not apply the patch
1) Set the system preference DisplayMultiPlaceHold to enable
2) Search in staff client catalogue
3) On results page check more then one result and click on Place hold
button at the top of the page
4) Search for patron, but don't be to specific, you need to have more
then one result
5) Click on one of the found patron
6) Now you are going to confirm a hold, but only for one record!
7) Apply the patch
8) Repeat 2-5 and confirm that now it is working as expected ( place
    hold for multiple records)

Signed-off-by: delaye <stephane.delaye@biblibre.com>
Comment 4 Maksim Sen 2018-03-16 19:12:01 UTC
Created attachment 73060 [details] [review]
Bug 20392: Fix handling multi hold when not patron set

Test plan:
0) Do not apply the patch
1) Set the system preference DisplayMultiPlaceHold to enable
2) Search in staff client catalogue
3) On results page check more then one result and click on Place hold
button at the top of the page
4) Search for patron, but don't be to specific, you need to have more
then one result
5) Click on one of the found patron
6) Now you are going to confirm a hold, but only for one record!
7) Apply the patch
8) Repeat 2-5 and confirm that now it is working as expected ( place
    hold for multiple records)

Signed-off-by: delaye <stephane.delaye@biblibre.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>
Comment 5 Kyle M Hall 2018-03-30 11:15:45 UTC
Created attachment 73466 [details] [review]
Bug 20392: Fix handling multi hold when not patron set

Test plan:
0) Do not apply the patch
1) Set the system preference DisplayMultiPlaceHold to enable
2) Search in staff client catalogue
3) On results page check more then one result and click on Place hold
button at the top of the page
4) Search for patron, but don't be to specific, you need to have more
then one result
5) Click on one of the found patron
6) Now you are going to confirm a hold, but only for one record!
7) Apply the patch
8) Repeat 2-5 and confirm that now it is working as expected ( place
    hold for multiple records)

Signed-off-by: delaye <stephane.delaye@biblibre.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2018-03-30 11:17:09 UTC
Bug 18474 and Bug 20392 appear to solve the same problem. Leaving to RM to decide which to use!
Comment 7 Jonathan Druart 2018-04-02 19:25:48 UTC

*** This bug has been marked as a duplicate of bug 18474 ***