Summary: | Remove OpacBrowseResults system preference and make it always on | ||
---|---|---|---|
Product: | Koha | Reporter: | Gaetan Boisson <gaetan.boisson> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | katrin.fischer, marjorie.barry-vila |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 20396 |
Description
Gaetan Boisson
2018-03-14 16:35:43 UTC
It relies heavily on JavaScript and doesn't work right without. I'd like to keep the option to deactivate it in a clean way. Well the decision to turn the syspref on or off belongs to the library, not to the end user that has javascript or not. So hypothetical users that don't have javascript will see an interface that they cannot use indeed, and won't have their say about it anyway. I would argue such clients probably deal with this somehow already considering how common it is. If this is really an issue, then this feature should be refactored to work without javascript. But in all cases i think the system preference here isn't really required, so different issue in my opinion. I agree that we could remove the system preference after some refactoring. We should also make sure some id and classes are in place to still be able to hide it. We have a lot of switches for OPAC features - I am not sure if this pref hurts anyone - but would be nice to get more opinions. |