Bug 20409 - Remove OpacBrowseResults system preference and make it always on
Summary: Remove OpacBrowseResults system preference and make it always on
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 20396
  Show dependency treegraph
 
Reported: 2018-03-14 16:35 UTC by Gaetan Boisson
Modified: 2019-02-25 15:08 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gaetan Boisson 2018-03-14 16:35:43 UTC
According to HEA, this is always on.

I don't think it should be a system preference. Libraries that *really* don't want this useful feature (which don't seem to exist at the moment) could still hide it with css.
Comment 1 Katrin Fischer 2018-03-17 09:06:49 UTC
It relies heavily on JavaScript and doesn't work right without. I'd like to keep the option to deactivate it in a clean way.
Comment 2 Gaetan Boisson 2018-03-19 10:48:15 UTC
Well the decision to turn the syspref on or off belongs to the library, not to the end user that has javascript or not. So hypothetical users that don't have javascript will see an interface that they cannot use indeed, and won't have their say about it anyway.

I would argue such clients probably deal with this somehow already considering how common it is.

If this is really an issue, then this feature should be refactored to work without javascript. But in all cases i think the system preference here isn't really required, so different issue in my opinion.
Comment 3 Katrin Fischer 2018-03-30 13:21:27 UTC
I agree that we could remove the system preference after some refactoring. We should also make sure some id and classes are in place to still be able to hide it.
Comment 4 Owen Leonard 2018-06-29 16:55:33 UTC
See also Bug 20898.