|
Description
François Pichenot
2018-03-15 14:14:02 UTC
*** Bug 23737 has been marked as a duplicate of this bug. *** Created attachment 93732 [details]
bib1.att
Created attachment 93733 [details]
biblio-koha-indexdefs.xml
Created attachment 93736 [details]
ccl.properties
*** Bug 11050 has been marked as a duplicate of this bug. *** Created attachment 119034 [details] [review] Bug 20424: Add new zebra indexes for the last IFLA updates Just turned the 3 attached files into a patch so that it's easier to apply Created attachment 119053 [details] [review] Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates Created attachment 119054 [details] [review] Bug 20424: provides biblio-zebra-indexdefs.xsl Created attachment 119080 [details] [review] Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates Created attachment 119081 [details] [review] Bug 20424: provides biblio-zebra-indexdefs.xsl Thanks Alex for the new patches. I'm testing right now and I'm wondering if we couldn't enhance the search on the new index : Identifier-persistent (on fields 003 and 033$a) Is it normal that when I tried : localhost:8080/cgi-bin/koha/opac-search.pl?advsearch=1&idx=Identifier-persistent&q=ARK%3A99 I found a biblio with : 033 : http://www.sudoc.fr/001018426 and 033$a=https://catalogue.bnf.fr/ark:/12148/cb34368226v and 033$a=https://reseau-mirabel.info/revue/titre-id/9939 I was expecting to find a biblio with : 003 like ARK:99 or 033$a like ARK:99 Do you think we could change that ? Thanks Hi Alex We tested the patch last week, most of it works great, thanks. Only three indexes we couldn't use : - carrier-type - identifier-persistent (we were not able to reproduce comment #12 search) - char-encoding I'm not sure if we had the syntax right (we used intranet search, with "Index-name:search", it worked for most, not for those 3) or if it's a problem with the patch. Created attachment 132663 [details] [review] Bug 20424: adds new indexes as availables in C4::Search Hi,
We have just noticed that the char-encoding should'nt be indexed as number.
And that position 30 to 34 should be splitted: it's twice a 2 characters value.
So, we have this proposition for the xml file.
<index_subfields tag="100" subfields="a" offset="26" length="2">
<target_index>char-encoding:w</target_index>
<target_index>char-encoding:p</target_index>
</index_subfields>
<index_subfields tag="100" subfields="a" offset="28" length="2">
<target_index>char-encoding:w</target_index>
<target_index>char-encoding:p</target_index>
</index_subfields>
<index_subfields tag="100" subfields="a" offset="30" length="2">
<target_index>char-encoding:w</target_index>
<target_index>char-encoding:p</target_index>
</index_subfields>
<index_subfields tag="100" subfields="a" offset="32" length="2">
<target_index>char-encoding:w</target_index>
<target_index>char-encoding:p</target_index>
</index_subfields>
Sonia
Created attachment 132816 [details] [review] Bug 20424: Add new zebra indexes for the last IFLA updates Created attachment 132817 [details] [review] Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates Created attachment 132818 [details] [review] Bug 20424: provides biblio-zebra-indexdefs.xsl Hi, We tested it on a kohadevbox. We tried all the indexes. It works. Thanks :-) Sonia Created attachment 132827 [details] [review] Bug 20424: Add new zebra indexes for the last IFLA updates Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Created attachment 132828 [details] [review] Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Created attachment 132829 [details] [review] Bug 20424: provides biblio-zebra-indexdefs.xsl Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Does what it's supposed to do but we need to clarify a few changes in the code. field 901 wasn't in the IFLA updates. What is it's new index for? Created attachment 148831 [details] [review] Bug 20424: Add new zebra indexes for the last IFLA updates Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Created attachment 148832 [details] [review] Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Created attachment 148833 [details] [review] Bug 20424: remove zebra index for field 901 Created attachment 148834 [details] [review] Bug 20424: provides biblio-zebra-indexdefs.xsl I'd be happy to test, but I don't know enough about Zebra indexes to test. If you could add a step-by-step test plan. Hi This should be reworked : - Some points are now obsolete (219 field does not exist anymore) - Too much changes in those patches I believe, and there should be summed up in commit description - Changes related to 099 field are not linked to IFLA updates, etc. Should be in a distinct bug - for 099$o (opac supress), there is a more specific ticket : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37600 - No test plan Not sure François Pichenot is still working on that. If needed I can take in charge the ticket |