Summary: | Can't sort patron search on date expired | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, josef.moravec, kyle.m.hall, mtompset, niamh.walker-headon, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 20145 | ||
Bug Blocks: | |||
Attachments: |
Bug 20455: Fix sort patrons by date expired
Bug 20455: Fix sort patrons by date expired Bug 20455: Fix sort patrons by date expired |
Description
Katrin Fischer
2018-03-20 21:31:54 UTC
Created attachment 73287 [details] [review] Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object kohadevbox reset_all in mysql client update borrowers set dateexpiry=null where borrowernumber=1 in staff client click patrons in top menu bar in left pane, search for 'a' as 'Surname'. list comes up. sort on 'Expires on', results in processing hang and errors as described in comment #0. Created attachment 73296 [details] [review] Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 73358 [details] [review] Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *** Bug 20331 has been marked as a duplicate of this bug. *** Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.06 Awesome work all! Pushed to 17.05.x for v17.05.12 |