Bug 20459

Summary: Correct message for cancelling an article request
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: OPACAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14610    
Bug Blocks:    
Attachments: Bug 20459: Correct message for cancelling an article request
Bug 20459: Correct message for cancelling an article request

Description Marcel de Rooy 2018-03-22 09:34:11 UTC
Cancel this hold was just copied/pasted with a TODO ;)
Comment 1 Marcel de Rooy 2018-03-22 09:54:23 UTC
Created attachment 73151 [details] [review]
Bug 20459: Correct message for cancelling an article request

We should not ask for 'cancel this hold'. Remove corresponding TODO.

Fix qa warning on old bootstrap style:
    btn btn-mini => btn btn-default btn-xs

Test plan:
Create an article request and cancel it on opac-user.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2018-03-22 09:56:17 UTC
String patch / moving to SO queue
Comment 3 Nick Clemens 2018-03-23 14:10:53 UTC
Created attachment 73183 [details] [review]
Bug 20459: Correct message for cancelling an article request

We should not ask for 'cancel this hold'. Remove corresponding TODO.

Fix qa warning on old bootstrap style:
    btn btn-mini => btn btn-default btn-xs
I removed above change, qa tool complaint is wrong (refers to staff, we
        are on opac)

Test plan:
Create an article request and cancel it on opac-user.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2018-03-26 20:39:01 UTC
Pushed to master for 18.05, thanks to everybody involved!