Summary: | Correct message for cancelling an article request | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14610 | ||
Bug Blocks: | |||
Attachments: |
Bug 20459: Correct message for cancelling an article request
Bug 20459: Correct message for cancelling an article request |
Description
Marcel de Rooy
2018-03-22 09:34:11 UTC
Created attachment 73151 [details] [review] Bug 20459: Correct message for cancelling an article request We should not ask for 'cancel this hold'. Remove corresponding TODO. Fix qa warning on old bootstrap style: btn btn-mini => btn btn-default btn-xs Test plan: Create an article request and cancel it on opac-user. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> String patch / moving to SO queue Created attachment 73183 [details] [review] Bug 20459: Correct message for cancelling an article request We should not ask for 'cancel this hold'. Remove corresponding TODO. Fix qa warning on old bootstrap style: btn btn-mini => btn btn-default btn-xs I removed above change, qa tool complaint is wrong (refers to staff, we are on opac) Test plan: Create an article request and cancel it on opac-user. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! |