Cancel this hold was just copied/pasted with a TODO ;)
Created attachment 73151 [details] [review] Bug 20459: Correct message for cancelling an article request We should not ask for 'cancel this hold'. Remove corresponding TODO. Fix qa warning on old bootstrap style: btn btn-mini => btn btn-default btn-xs Test plan: Create an article request and cancel it on opac-user. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
String patch / moving to SO queue
Created attachment 73183 [details] [review] Bug 20459: Correct message for cancelling an article request We should not ask for 'cancel this hold'. Remove corresponding TODO. Fix qa warning on old bootstrap style: btn btn-mini => btn btn-default btn-xs I removed above change, qa tool complaint is wrong (refers to staff, we are on opac) Test plan: Create an article request and cancel it on opac-user. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 18.05, thanks to everybody involved!