Summary: | Selenium tests fail if server not running | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED WONTFIX | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dcook, jonathan.druart, m.de.rooy, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20505: Patch selenium tests to skip gracefully
Bug 20505: Patch selenium tests to skip gracefully Bug 20505: Patch selenium tests to skip gracefully Bug 20505: Friendlier death message |
Description
Mark Tompsett
2018-04-01 14:41:48 UTC
Created attachment 73517 [details] [review] Bug 20505: Patch selenium tests to skip gracefully TEST PLAN --------- 1) In a koha shell on kohadevbox, run prove -v t/db_dependent/selenium until it doesn't skip because of missing dependencies, but rather because of not running a selenium server. 2) apply this patch and restart_all 3) rerun the tests -- they will skip gracefully and informatively. 4) run koha qa test tools Created attachment 74364 [details] [review] Bug 20505: Patch selenium tests to skip gracefully TEST PLAN --------- 1) In a koha shell on kohadevbox, run prove -v t/db_dependent/selenium until it doesn't skip because of missing dependencies, but rather because of not running a selenium server. 2) apply this patch and restart_all 3) rerun the tests -- they will skip gracefully and informatively. 4) run koha qa test tools Signed-off-by: Nick Clemens <nick@bywatersolutions.com> To trigger the test plan I installed the dependencies but did not setup the server Created attachment 75054 [details] [review] Bug 20505: Patch selenium tests to skip gracefully TEST PLAN --------- 1) In a koha shell on kohadevbox, run prove -v t/db_dependent/selenium until it doesn't skip because of missing dependencies, but rather because of not running a selenium server. 2) apply this patch and restart_all 3) rerun the tests -- they will skip gracefully and informatively. 4) run koha qa test tools Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I do not know if this is valid, I would prefer to explode if the server is not running and to know there is something wrong in the setup. The error is explicit: "Selenium server did not return proper status" This change could hide problems in jenkins configuration. Tomas, opinion? Created attachment 75136 [details] [review] Bug 20505: Friendlier death message Actually telling the user where to look to solve the problem is more helpful than just expecting them to know why the selenium driver didn't load. Failures should be in the test file, not nested deep in subcalls. prove t/db_dependent/selenium/ Closing this due to age and since koha-testing-docker makes this much easier these days |