Summary: | Re-indent moremember.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, mtompset, nick, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 20518 | ||
Bug Blocks: | 20779 | ||
Attachments: |
Bug 20520: Re-indent moremember.tt
Bug 20520: Re-indent moremember.tt Bug 20520: Re-indent moremember.tt Bug 20520: Re-indent moremember.tt Bug 20520: Re-indent moremember.tt |
Description
Owen Leonard
2018-04-04 17:11:25 UTC
Created attachment 75432 [details] [review] Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Conflicts. Please fix, and I'll retest. Created attachment 75488 [details] [review] Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Was there any real benefit to changing HTML comments to Template Toolkit comments? Nasty /div mismatches in some cases, as far as I could read. Also, layering issues with things not nested properly. Indentation really cleaned this up nicely. Created attachment 75500 [details] [review] Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #4) > Was there any real benefit to changing HTML comments to Template Toolkit > comments? The comments are for people editing the template, so there's not any reason to add to the file size of the generated HTML by outputting them there. Created attachment 75745 [details] [review] Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 76484 [details] [review] Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02, cosmetic code tidy up only. Enhancement and does not apply easily on 17.11.x. Not pushed |