Bug 20520 - Re-indent moremember.tt
Summary: Re-indent moremember.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 20518
Blocks: 20779
  Show dependency treegraph
 
Reported: 2018-04-04 17:11 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20520: Re-indent moremember.tt (71.19 KB, patch)
2018-05-18 13:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20520: Re-indent moremember.tt (71.17 KB, patch)
2018-05-23 13:12 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20520: Re-indent moremember.tt (71.23 KB, patch)
2018-05-23 14:16 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 20520: Re-indent moremember.tt (71.28 KB, patch)
2018-06-03 07:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20520: Re-indent moremember.tt (72.43 KB, patch)
2018-06-27 12:28 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-04-04 17:11:25 UTC
I would like to re-indent moremember.tt and remove trailing spaces.
Comment 1 Owen Leonard 2018-05-18 13:14:36 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2018-05-22 22:22:31 UTC
Conflicts. Please fix, and I'll retest.
Comment 3 Owen Leonard 2018-05-23 13:12:12 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2018-05-23 14:12:04 UTC
Was there any real benefit to changing HTML comments to Template Toolkit comments?

Nasty /div mismatches in some cases, as far as I could read. Also, layering issues with things not nested properly. Indentation really cleaned this up nicely.
Comment 5 Mark Tompsett 2018-05-23 14:16:32 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2018-05-23 14:18:12 UTC
(In reply to M. Tompsett from comment #4)
> Was there any real benefit to changing HTML comments to Template Toolkit
> comments?

The comments are for people editing the template, so there's not any reason to add to the file size of the generated HTML by outputting them there.
Comment 7 Katrin Fischer 2018-06-03 07:51:55 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2018-06-27 12:28:32 UTC
Created attachment 76484 [details] [review]
Bug 20520: Re-indent moremember.tt

This patch reindents the template for the patron detail page,
moremember.tt:

- Trailing spaces removed
- Indentation changed to a consistent 4 spaces
- Markup indentation made more consistent

To test, view the patron detail page. There should be no visible
difference before and after the applying the patch.

HTML validation before and after the patch should return the same
results.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Owen Leonard 2018-06-27 12:28:45 UTC
Rebased.
Comment 10 Nick Clemens 2018-06-29 21:04:03 UTC
Awesome work all!

Pushed to master for 18.11
Comment 11 Martin Renvoize 2018-07-02 09:11:13 UTC
Pushed to 18.05.x for 18.05.02, cosmetic code tidy up only.
Comment 12 Fridolin Somers 2018-07-04 14:04:38 UTC
Enhancement and does not apply easily on 17.11.x.
Not pushed