Summary: | Floating toolbar when editing vendors | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, maksim.sen, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20534: Floating toolbar when editing vendors
Bug 20534: Floating toolbar when editing vendors Bug 20534: Floating toolbar when editing vendors Bug 20534: Floating toolbar when editing vendors Bug 20534: Floating toolbar when editing vendors |
Description
Katrin Fischer
2018-04-06 09:06:41 UTC
Created attachment 73772 [details] [review] Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Created attachment 73786 [details] [review] Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Created attachment 73826 [details] [review] Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I wish all my wishes came true so fast :) Works flawlessly, thx Owen! Owen, same problem as we had on the patron edit page: https://screenshots.firefox.com/pvWlqcxFqUDgRU0L/pro.kohadev.org Created attachment 79306 [details] [review] Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79307 [details] [review] Bug 20534: Floating toolbar when editing vendors This patch moves the Save and Cancel controls on the vendor edit form into a toolbar which sticks to the top of the screen as you scroll. To test, apply the patch and Acquisitions -> New vendor. - Confirm that as you scroll down the page, the toolbar with the Save and Cancel buttons sticks to the top of the screen. - Test that the Save and Cancel buttons both work correctly. - Perform the same tests when editing an existing vendor. Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |