Bug 20572

Summary: Refactor AddIssuingCharges parameter to hashref
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Fines and feesAssignee: Mark Tompsett <mtompset>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20562    
Bug Blocks:    
Attachments: Bug 20572: Refactor to hashref parameter

Description Mark Tompsett 2018-04-12 13:38:37 UTC
Jonathan Druart requested no refactor patches on major+ bugs be done. This does a rework of the parameters in bug 20562.
Comment 1 Mark Tompsett 2018-04-12 13:44:48 UTC
Created attachment 74096 [details] [review]
Bug 20572: Refactor to hashref parameter

Small refactor. Added more tests to confirm no
typos snuck in.

TEST PLAN
---------
apply bug 20562
perldoc C4::Circulation
-- look for the AddIssuingCharge part.
prove t/db_dependent/Circulation/issue.t
-- should pass
apply this patch
perldoc C4::Circulation
-- look for the AddIssuingCharge part.
prove t/db_dependent/Circulation/issue.t
-- should pass
Comment 2 Mark Tompsett 2019-01-10 01:58:17 UTC
The AddingIssuingCharges was changed to pass an Issue object in another bug. This is no longer relevant.