Bug 20572 - Refactor AddIssuingCharges parameter to hashref
Summary: Refactor AddIssuingCharges parameter to hashref
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on: 20562
Blocks:
  Show dependency tree / graph
 
Reported: 2018-04-12 13:38 UTC by Mark Tompsett
Modified: 2020-01-06 20:15 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 20572: Refactor to hashref parameter (3.90 KB, patch)
2018-04-12 13:44 UTC, Mark Tompsett 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2018-04-12 13:38:37 UTC 
Jonathan Druart requested no refactor patches on major+ bugs be done. This does a rework of the parameters in bug 20562.
Comment 1 Mark Tompsett 2018-04-12 13:44:48 UTC 
Created attachment 74096 [details] [review]
Bug 20572: Refactor to hashref parameter

Small refactor. Added more tests to confirm no
typos snuck in.

TEST PLAN
---------
apply bug 20562
perldoc C4::Circulation
-- look for the AddIssuingCharge part.
prove t/db_dependent/Circulation/issue.t
-- should pass
apply this patch
perldoc C4::Circulation
-- look for the AddIssuingCharge part.
prove t/db_dependent/Circulation/issue.t
-- should pass
Comment 2 Mark Tompsett 2019-01-10 01:58:17 UTC 
The AddingIssuingCharges was changed to pass an Issue object in another bug. This is no longer relevant.