Bug 20572 - Refactor AddIssuingCharges parameter to hashref
Summary: Refactor AddIssuingCharges parameter to hashref
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: M. Tompsett
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 20562
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-12 13:38 UTC by M. Tompsett
Modified: 2018-04-12 13:44 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20572: Refactor to hashref parameter (3.90 KB, patch)
2018-04-12 13:44 UTC, M. Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description M. Tompsett 2018-04-12 13:38:37 UTC
Jonathan Druart requested no refactor patches on major+ bugs be done. This does a rework of the parameters in bug 20562.
Comment 1 M. Tompsett 2018-04-12 13:44:48 UTC
Created attachment 74096 [details] [review]
Bug 20572: Refactor to hashref parameter

Small refactor. Added more tests to confirm no
typos snuck in.

TEST PLAN
---------
apply bug 20562
perldoc C4::Circulation
-- look for the AddIssuingCharge part.
prove t/db_dependent/Circulation/issue.t
-- should pass
apply this patch
perldoc C4::Circulation
-- look for the AddIssuingCharge part.
prove t/db_dependent/Circulation/issue.t
-- should pass