Bug 20576

Summary: t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t fails if Elasticsearch is configured but not running
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Test SuiteAssignee: Mark Tompsett <mtompset>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: black23, david
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18738
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20576: Skip without dying horribly
Bug 20576: Skip gracefully with a meaningful message

Description Mark Tompsett 2018-04-13 00:35:29 UTC
Similar to bug 18738, except with Koha_SearchEngine_Elasticsearch_Search.t
Comment 1 Mark Tompsett 2018-04-13 02:12:53 UTC
Created attachment 74120 [details] [review]
Bug 20576: Skip without dying horribly

TEST PLAN
---------
no elasticsearch section in koha-conf.xml
prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
-- nasty
elasticsearch, but no nodes
prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
-- ugly
apply patch
re-run above cases
-- unique skips
run qa test tools
Comment 2 Mark Tompsett 2019-06-20 18:45:15 UTC
Created attachment 90865 [details] [review]
Bug 20576: Skip gracefully with a meaningful message
Comment 3 David Nind 2020-03-07 09:14:09 UTC
Patch no longer applies:

Applying: Bug 20576: Skip gracefully with a meaningful message
Using index info to reconstruct a base tree...
M	t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t
CONFLICT (content): Merge conflict in t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20576: Skip gracefully with a meaningful message