Bug 20588

Summary: Elasticsearch - Apply dataTable on search fields and mapping tables
Product: Koha Reporter: Alex Arnaud <alex.arnaud>
Component: Searching - ElasticsearchAssignee: Alex Arnaud <alex.arnaud>
Status: Signed Off --- QA Contact:
Severity: enhancement    
Priority: P5 - low CC: axel.amghar, e.betemps, jonathan.druart, julian.maurice, katrin.fischer, nicolas.legrand, severine.queune
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20388    
Bug Blocks: 22639, 22994    
Attachments: Bug 20588 - Apply dataTable on search fields and mapping tables
Bug 20588 - Apply dataTable on search fields and mapping tables
Bug 20588 - Apply dataTable on search fields and mapping tables
Bug 20588 - Apply dataTable on search fields and mapping tables
Bug 20588: Apply dataTable on search fields and mapping tables
Bug 20588: Apply dataTable on search fields and mapping tables

Description Alex Arnaud 2018-04-16 14:29:22 UTC
Apply dataTable on search fields and mapping tables to be able to sort and filter data.
Comment 1 Alex Arnaud 2018-04-16 14:38:54 UTC Comment hidden (obsolete)
Comment 2 Nicolas Legrand 2018-04-17 09:38:31 UTC Comment hidden (obsolete)
Comment 3 Alex Arnaud 2018-04-17 09:56:40 UTC Comment hidden (obsolete)
Comment 4 Nicolas Legrand 2018-04-17 10:18:55 UTC Comment hidden (obsolete)
Comment 5 Alex Arnaud 2018-04-17 10:45:30 UTC Comment hidden (obsolete)
Comment 6 Alex Arnaud 2018-04-17 10:46:53 UTC
I've rebased the patch. Please try again
Comment 7 Jonathan Druart 2018-04-17 11:32:28 UTC
Looks like this patch removes the ability to sort the table (plugin tablednd), and store this order in DB. Are you sure we do no longer need that?
Comment 8 Séverine Queune 2018-04-17 11:51:04 UTC Comment hidden (obsolete)
Comment 9 Séverine Queune 2018-04-17 11:52:12 UTC
Jonathan has an other view of the patch.
As user, it looks pretty good to me !
Comment 10 Alex Arnaud 2018-04-18 08:24:39 UTC
(In reply to Jonathan Druart from comment #7)
> Looks like this patch removes the ability to sort the table (plugin
> tablednd), and store this order in DB. Are you sure we do no longer need
> that?

This patch exactly add the ability to sort tables columns. And, if i understand what you are talking about, we don't lose the drag and drop feature provided by tableDnD plugin.
Comment 11 Jonathan Druart 2018-04-18 13:35:25 UTC
Sorting by user's preference I meant, not sorting by alpha/num

Moreover the drag and drop functionality does not longer work after one of the column has been sorted.

I do not remember if this is used, could be useful later, or totally useless.
Comment 12 Julian Maurice 2018-09-14 09:48:21 UTC
Changing status to BLOCKED, as it depends on 20388, which needs a rebase.
Comment 13 Alex Arnaud 2018-09-14 14:04:07 UTC Comment hidden (obsolete)
Comment 14 Katrin Fischer 2019-02-02 21:59:45 UTC
BLOCKED by bug 20338 dependency being Needs Signoff.
Comment 15 Katrin Fischer 2019-03-29 13:29:09 UTC
(In reply to Katrin Fischer from comment #14)
> BLOCKED by bug 20338 dependency being Needs Signoff.

Should be BLOCKED by bug 20388 - which is signed off now, so unlocking.
Comment 16 Katrin Fischer 2019-06-02 15:27:44 UTC
Blocked by dependency bug 20388 awaiting sign-off.
Comment 17 axel Amghar 2019-06-13 12:34:56 UTC
Created attachment 90576 [details] [review]
Bug 20588: Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings
Comment 18 axel Amghar 2019-06-13 12:54:42 UTC
I just made a rebase
Comment 19 axel Amghar 2019-06-13 12:57:02 UTC
*** Bug 19598 has been marked as a duplicate of this bug. ***
Comment 20 Michal Denar 2019-06-13 19:50:06 UTC
Created attachment 90585 [details] [review]
Bug 20588: Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings

Signed-off-by: Michal Denar <black23@gmail.com>