Bug 20588 - Elasticsearch - Apply dataTable on search fields and mapping tables
Summary: Elasticsearch - Apply dataTable on search fields and mapping tables
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Alex Arnaud
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 20388
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-16 14:29 UTC by Alex Arnaud
Modified: 2018-10-22 16:38 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20588 - Apply dataTable on search fields and mapping tables (10.23 KB, patch)
2018-04-16 14:38 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 20588 - Apply dataTable on search fields and mapping tables (10.09 KB, patch)
2018-04-17 10:45 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 20588 - Apply dataTable on search fields and mapping tables (10.23 KB, patch)
2018-04-17 11:51 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 20588 - Apply dataTable on search fields and mapping tables (10.45 KB, patch)
2018-09-14 14:04 UTC, Alex Arnaud
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Arnaud 2018-04-16 14:29:22 UTC
Apply dataTable on search fields and mapping tables to be able to sort and filter data.
Comment 1 Alex Arnaud 2018-04-16 14:38:54 UTC Comment hidden (obsolete)
Comment 2 Nicolas Legrand 2018-04-17 09:38:31 UTC Comment hidden (obsolete)
Comment 3 Alex Arnaud 2018-04-17 09:56:40 UTC Comment hidden (obsolete)
Comment 4 Nicolas Legrand 2018-04-17 10:18:55 UTC Comment hidden (obsolete)
Comment 5 Alex Arnaud 2018-04-17 10:45:30 UTC Comment hidden (obsolete)
Comment 6 Alex Arnaud 2018-04-17 10:46:53 UTC
I've rebased the patch. Please try again
Comment 7 Jonathan Druart 2018-04-17 11:32:28 UTC
Looks like this patch removes the ability to sort the table (plugin tablednd), and store this order in DB. Are you sure we do no longer need that?
Comment 8 Séverine Queune 2018-04-17 11:51:04 UTC
Created attachment 74315 [details] [review]
Bug 20588 - Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 9 Séverine Queune 2018-04-17 11:52:12 UTC
Jonathan has an other view of the patch.
As user, it looks pretty good to me !
Comment 10 Alex Arnaud 2018-04-18 08:24:39 UTC
(In reply to Jonathan Druart from comment #7)
> Looks like this patch removes the ability to sort the table (plugin
> tablednd), and store this order in DB. Are you sure we do no longer need
> that?

This patch exactly add the ability to sort tables columns. And, if i understand what you are talking about, we don't lose the drag and drop feature provided by tableDnD plugin.
Comment 11 Jonathan Druart 2018-04-18 13:35:25 UTC
Sorting by user's preference I meant, not sorting by alpha/num

Moreover the drag and drop functionality does not longer work after one of the column has been sorted.

I do not remember if this is used, could be useful later, or totally useless.
Comment 12 Julian Maurice 2018-09-14 09:48:21 UTC
Changing status to BLOCKED, as it depends on 20388, which needs a rebase.
Comment 13 Alex Arnaud 2018-09-14 14:04:07 UTC
Created attachment 78660 [details] [review]
Bug 20588 - Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>