Bug 20599

Summary: Add the Koha::Subscription->vendor method
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 18426    
Attachments: Bug 20599: Add the Koha::Subscription->vendor method
Bug 20599: Add the Koha::Subscription->vendor method
Bug 20599: Add the Koha::Subscription->vendor method

Description Jonathan Druart 2018-04-17 21:12:37 UTC
To access the vendor of a subscription easily
Comment 1 Jonathan Druart 2018-04-17 21:13:24 UTC
Created attachment 74392 [details] [review]
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green
Comment 2 Mark Tompsett 2018-04-18 01:21:38 UTC
Created attachment 74401 [details] [review]
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

NOTE: My preference is for $subscription to be object,
      and perhaps something like $built_subscription to
      be from the builder. Because, $object is a poor
      variable name.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Katrin Fischer 2018-04-18 06:06:09 UTC
Created attachment 74403 [details] [review]
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

NOTE: My preference is for $subscription to be object,
      and perhaps something like $built_subscription to
      be from the builder. Because, $object is a poor
      variable name.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2018-04-19 15:43:08 UTC
Pushed to master for 18.05, thanks to everybody involved!