| Summary: | C4::Acounts claims to use ReturnLostItem but doesn't | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Architecture, internals, and plumbing | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, josef.moravec, martin.renvoize, nick |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15896 | ||
| Bug Blocks: | 21396 | ||
| Attachments: |
Bug 20631: Remove unused RemoveLostItem from C4::Accounts
Bug 20631: Remove unused RemoveLostItem from C4::Accounts Bug 20631: Remove unused RemoveLostItem from C4::Accounts |
||
|
Description
Katrin Fischer
2018-04-21 11:16:57 UTC
Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment Created attachment 77603 [details] [review] Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Created attachment 77714 [details] [review] Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 78048 [details] [review] Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03 Pushed to 17.11.x for 17.11.10 It is Koha::Account that uses ReturnLostItem now. This module is missing use C4::Circulation maybe ? (In reply to Fridolin SOMERS from comment #7) > Pushed to 17.11.x for 17.11.10 > > It is Koha::Account that uses ReturnLostItem now. > This module is missing use C4::Circulation maybe ? Yes, see bug 21396 |