1. require C4::Letters must be use C4::Letters 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation
Created attachment 79255 [details] [review] Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed
Created attachment 79407 [details] [review] Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 79486 [details] [review] Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
(In reply to Martin Renvoize from comment #5) > Pushed to 18.05.x for 18.05.05 This one causes the failing test on Jenkins koha_1 | Undefined subroutine &C4::Items::ModZebra called at /kohadevbox/koha/C4/Items.pm line 302.
(In reply to Jonathan Druart from comment #6) > (In reply to Martin Renvoize from comment #5) > > Pushed to 18.05.x for 18.05.05 > > This one causes the failing test on Jenkins > koha_1 | Undefined subroutine &C4::Items::ModZebra called at > /kohadevbox/koha/C4/Items.pm line 302. See bug 21133, I have attached a version for 18.05.x
Bug 19191 nor Bug 20631 in 17.11.x but must it be pushed anyway ?
(In reply to Fridolin SOMERS from comment #8) > Bug 19191 nor Bug 20631 in 17.11.x but must it be pushed anyway ? If there is the call to ReturnLostItem, yes.
Ok there is ReturnLostItem, Pushed to 17.11.x for 17.11.12
(In reply to Fridolin SOMERS from comment #10) > Ok there is ReturnLostItem, > > Pushed to 17.11.x for 17.11.12 Ok not OK, it brakes UT t/db_dependent/Members/GetOverdues.t t/db_dependent/Members/GetPendingIssues.t I dont understand why, I revert.
Created attachment 81981 [details] [review] [17.11.x] Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed
Created attachment 81982 [details] [review] Bug 21396: Fix tests for 17.11
(In reply to Fridolin SOMERS from comment #11) > (In reply to Fridolin SOMERS from comment #10) > > Ok there is ReturnLostItem, > > > > Pushed to 17.11.x for 17.11.12 > > Ok not OK, it brakes UT > t/db_dependent/Members/GetOverdues.t > t/db_dependent/Members/GetPendingIssues.t > > I dont understand why, I revert. These test files do no longer exist in master, and so have not been modified by bug 21133.