| Summary: | Holds to pull: filter shows two itypes on the same line if a biblio has two items of a different type | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> | 
| Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | minor | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, m.de.rooy, martin.renvoize, nick | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | It shows the two item types combined. Bug 20637: Fix filters content on the holds to pull screen Bug 20637: Fix filters content on the holds to pull screen Bug 20637: Fix filters content on the holds to pull screen | ||
| Follow up of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972#c4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972#c8 Created attachment 74821 [details] [review] Bug 20637: Fix filters content on the holds to pull screen libraries and locations are separated by <br> whereas itypes are using \n This patch standardized the separator to generate correctly the filters pulldown Test plan: - Place a hold on a biblio record which has several items - Define different location and itypes for these items - Display the hold on the "Holds to pull" screen and make sure the filters are working correctly (focus on the dropdown list) Created attachment 74881 [details] [review] Bug 20637: Fix filters content on the holds to pull screen libraries and locations are separated by <br> whereas itypes are using \n This patch standardized the separator to generate correctly the filters pulldown Test plan: - Place a hold on a biblio record which has several items - Define different locations and itypes for these items - Display the holds on the "Holds to pull" screen and make sure the filters are working correctly (focus on the dropdown list) Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> itypes got fixed and no regressions on libraries and locations. Works great, thanks! Created attachment 74927 [details] [review] Bug 20637: Fix filters content on the holds to pull screen libraries and locations are separated by <br> whereas itypes are using \n This patch standardized the separator to generate correctly the filters pulldown Test plan: - Place a hold on a biblio record which has several items - Define different locations and itypes for these items - Display the holds on the "Holds to pull" screen and make sure the filters are working correctly (focus on the dropdown list) Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! | 
Created attachment 74731 [details] It shows the two item types combined. The screenshot shows the two item types combined. The issue is in the dropdown menu.