Bug 20637

Summary: Holds to pull: filter shows two itypes on the same line if a biblio has two items of a different type
Product: Koha Reporter: Victor Grousset/tuxayo <victor>
Component: Hold requestsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, jonathan.druart, katrin.fischer, kyle, m.de.rooy, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: It shows the two item types combined.
Bug 20637: Fix filters content on the holds to pull screen
Bug 20637: Fix filters content on the holds to pull screen
Bug 20637: Fix filters content on the holds to pull screen

Description Victor Grousset/tuxayo 2018-04-23 13:57:11 UTC
Created attachment 74731 [details]
It shows the two item types combined.

The screenshot shows the two item types combined.

The issue is in the dropdown menu.
Comment 2 Jonathan Druart 2018-04-24 18:28:15 UTC
Created attachment 74821 [details] [review]
Bug 20637: Fix filters content on the holds to pull screen

libraries and locations are separated by <br> whereas itypes are using
\n
This patch standardized the separator to generate correctly the filters
pulldown

Test plan:
- Place a hold on a biblio record which has several items
- Define different location and itypes for these items
- Display the hold on the "Holds to pull" screen and make sure the
filters are working correctly (focus on the dropdown list)
Comment 3 Victor Grousset/tuxayo 2018-04-26 13:06:20 UTC
Created attachment 74881 [details] [review]
Bug 20637: Fix filters content on the holds to pull screen

libraries and locations are separated by <br> whereas itypes are using
\n
This patch standardized the separator to generate correctly the filters
pulldown

Test plan:
- Place a hold on a biblio record which has several items
- Define different locations and itypes for these items
- Display the holds on the "Holds to pull" screen and make sure the
filters are working correctly (focus on the dropdown list)

Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
Comment 4 Victor Grousset/tuxayo 2018-04-26 13:07:26 UTC
itypes got fixed and no regressions on libraries and locations.

Works great, thanks!
Comment 5 Katrin Fischer 2018-04-29 22:38:32 UTC
Created attachment 74927 [details] [review]
Bug 20637: Fix filters content on the holds to pull screen

libraries and locations are separated by <br> whereas itypes are using
\n
This patch standardized the separator to generate correctly the filters
pulldown

Test plan:
- Place a hold on a biblio record which has several items
- Define different locations and itypes for these items
- Display the holds on the "Holds to pull" screen and make sure the
filters are working correctly (focus on the dropdown list)

Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Jonathan Druart 2018-05-03 16:41:30 UTC
Pushed to master for 18.05, thanks to everybody involved!