Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug.
Created attachment 70549 [details] [review] Bug 19972: pendingreserves.pl now honors syspref "item-level_itypes" And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref
Patch tested with a sandbox, by Lucie Gay <lucie.gay@ens-paris-saclay.fr>
Created attachment 72804 [details] [review] Bug 19972: pendingreserves.pl now honors syspref "item-level_itypes" And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr>
Maybe type-filter is not the best of names? This filter currently works a bit weird, and also with your patch. If a biblio has two items of a different type, I see two item types on one line in the dropdown. Can we fix it here or is it already out of scope?
(In reply to Marcel de Rooy from comment #4) > Maybe type-filter is not the best of names? Which name can I use to replace it? > This filter currently works a bit weird, and also with your patch. > If a biblio has two items of a different type, I see two item types on one > line in the dropdown. Can we fix it here or is it already out of scope? I must be a followup patch anyway (already signed off) so can it be another bugzilla?
Created attachment 74706 [details] [review] Bug 19972: Make holds to pull list honors item-level_itypes syspref And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74707 [details] [review] Bug 19972: (QA follow-up) Fix id name Renames #type-filter to #itemtype-filter
Victor, please file another bug for the problem with the datatables filter, thx!
(In reply to Katrin Fischer from comment #7) > Created attachment 74707 [details] [review] [review] > Bug 19972: (QA follow-up) Fix id name > > Renames #type-filter to #itemtype-filter Thanks, I didn't dare to name it itemtype or itype because it can actually be both. So I though it would be confusing.
(In reply to Victor Grousset/tuxayo from comment #9) > (In reply to Katrin Fischer from comment #7) > > Created attachment 74707 [details] [review] [review] [review] > > Bug 19972: (QA follow-up) Fix id name > > > > Renames #type-filter to #itemtype-filter > > Thanks, I didn't dare to name it itemtype or itype because it can actually > be both. So I though it would be confusing. I wouldn't overthink the name. I think not naming them the same was just a historical QA oversight.
Created attachment 74878 [details] [review] Bug 19972: Make holds to pull list honors item-level_itypes syspref And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74879 [details] [review] Bug 19972: (QA follow-up) Fix id name Renames #type-filter to #itemtype-filter
- rebased and solved a conflict - retried the test plan - did a diff between the previous patches file; to check that the rebased didn't impacted the actual changes; and confirm that a new sign off should be required
Pushed to master for 18.05, thanks to everybody involved!
Oups, I should have wrote «and confirm that a new sign off should **not** be required» Thanks Jonathan for still understanding ^^ and having moved the patch forward! :D
Pushed to 17.11.x for 17.11.07. Easy rebase conflict because JS has moved to bottom.