| Summary: | Improve display of "Toggle full supplier metadata" | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
| Component: | ILL | Assignee: | Andrew Isherwood <bugzilla> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | joe.mcglynn, jonathan.druart, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 7317 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 20561: Improve full supplier metadata display
Bug 20561: Improve full supplier metadata display Bug 20561: Improve full supplier metadata display Bug 20561: Improve full supplier metadata display Bug 20561: Improve full supplier metadata display Bug 20561: Improve full supplier metadata display Bug 20651: Improve full supplier metadata display |
||
|
Description
Andrew Isherwood
2018-04-24 14:03:32 UTC
Created attachment 74812 [details] [review] Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Created attachment 74836 [details] [review] Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Created attachment 75277 [details] [review] Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger <magnus@enger.priv.no> The modal looks good! Fix the indentation please. Created attachment 75627 [details] [review] Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger <magnus@enger.priv.no> The modal looks good! Created attachment 75655 [details] [review] Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata I've just attached a new patch that addresses the indentation, thanks for the feedback Jonathan :) If Owen agrees, it's ok for me. Created attachment 76072 [details] [review] Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger <magnus@enger.priv.no> The modal looks good! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 76073 [details] [review] Bug 20651: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger <magnus@enger.priv.no> The modal looks good! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Enhancement, not backporting to 18.05.x series. |