Bug 20659

Summary: Blocking errors are not longer displayed
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18403    
Bug Blocks:    
Attachments: Bug 20659: Fix blocking errors display

Description Jonathan Druart 2018-04-25 19:51:55 UTC
The include file blocking-errors.inc has been created to by-pass regular processing and display an error that should block the elements of the view.

For instance you call a patron's page with invalid borrowernumber => we do not want the app to crash (500) or the page to display with broken elements.

It worked well on bug 18403 but it's now broken, a blank page is displayed instead.
It may be caused by the move of the JS to the bottom of the page.
Comment 1 Jonathan Druart 2018-04-25 19:53:08 UTC
Created attachment 74856 [details] [review]
Bug 20659: Fix blocking errors display

The include file blocking-errors.inc has been created to by-pass regular
processing and display an error that should block the elements of the
view.

For instance you call a patron's page with invalid borrowernumber => we
do not want the app to crash (500) or the page to display with broken
elements.

It worked well on bug 18403 but it's now broken, a blank page is
displayed instead.
It may be caused by the move of the JS to the bottom of the page.

Test plan:
hit /cgi-bin/koha/members/moremember.pl?borrowernumber=45432
Without this patch a blank page is displayed.
With this patch you see the blocking error
Comment 2 Jonathan Druart 2018-04-25 19:53:55 UTC
Patch pushed to master for 18.05