Description
Mason James
2018-05-01 21:19:36 UTC
Created attachment 74958 [details] [review] Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed to test patch... 1/ build koha package from souce, install package 2/ test plack, see following error... Error while loading /etc/koha/plack.psgi: Can't locate CGI/Emulate/PSGI.pm in @INC (you may need to install the CGI::Emulate::PSGI module) 3/ apply patch 4/ build koha package from souce, install package 5/ test plack, see no error and observe plack is working (In reply to Mason James from comment #1) > Created attachment 74958 [details] [review] [review] > Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not > installed > > to test patch... > > 1/ build koha package from souce, install package > > 2/ test plack, see following error... > > Error while loading /etc/koha/plack.psgi: Can't locate CGI/Emulate/PSGI.pm > in @INC (you may need to install the CGI::Emulate::PSGI module) > > 3/ apply patch > > 4/ build koha package from souce, install package > > 5/ test plack, see no error and observe plack is working aah, false alarm... # aptitude why libcgi-emulate-psgi-perl i koha-common Depends starman i A starman Depends libplack-perl i A libplack-perl Recommends libcgi-emulate-psgi-perl (In reply to Mason James from comment #2) > aah, false alarm... > > # aptitude why libcgi-emulate-psgi-perl > i koha-common Depends starman > i A starman Depends libplack-perl > i A libplack-perl Recommends libcgi-emulate-psgi-perl That still seems like a problem to me? If it's not in the PerlDependencies.pm, then any non-package install will run into dependency problems? Reopening: % aptitude why libcgi-emulate-psgi-perl Unable to find a reason to install libcgi-emulate-psgi-perl. % more /etc/debian_version 8.10 With 9.1 I get: % aptitude why libcgi-emulate-psgi-perl i libplack-middleware-fixmissingbodyinredirect-perl Depends libplack-perl i A libplack-perl Recommends libcgi-emulate-psgi-perl From Magnuse on IRC, Ubuntu 16.04 returns: i libcgi-compile-perl Recommends libcgi-emulate-psgi-per Mason: What OS did you install on, and does it have special apt configuration? The package is recommended by a dependency, it should be installed unless you changed the apt config to ignore recommended packages.
Jonathan: Is Koha actually installed on the 8.10 system you tried? I get on 8.10
>aptitude why libcgi-emulate-psgi-perl
>i koha-common Depends starman
>i A starman Depends libplack-perl
>i A libplack-perl Recommends libcgi-emulate-psgi-perl
Anyway, recommended packages are installed by default in Debian. This can be disabled though, eg. if you are very low on disk space. If Koha relies on libcgi-emulate-psgi-perl to work, it should be a direct dependency.
The patch is not the way to do it. CGI::Emulate::PSGI should added to PerlDependencies.pm instead and I will add an updated control file.
Plack is a dependency of starman, both for Debian packages and on CPAN, adding Plack to PerlDependencies.pm is not necessary.
Created attachment 75327 [details] [review] Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed Add CGI::Emulate::PSGI to PerlDependencies.pm Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 75328 [details] [review] Bug 20693: Update control file Auto-generated file. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I chose the version number available in Jessie. Not really anything to test here, forwarding to QA. Take a look at the first patch to see it makes sense, you can see the effect in the second patch. Created attachment 75338 [details] [review] Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed Add CGI::Emulate::PSGI to PerlDependencies.pm Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 75339 [details] [review] Bug 20693: Update control file Auto-generated file. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 18.05, thanks to everybody involved! Fridolin: Needs to go to 17.11. Is in 17.11.07-2 package, please push for 17.11.08! Minor rebase needed, I'll send a changed patch. Created attachment 76599 [details] [review] Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed Add CGI::Emulate::PSGI to PerlDependencies.pm Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to 17.11.x for 17.11.08 Pushed to 17.05.x for 17.05.14 |