Bug 17421 - Missing dependency on CGI::Emulate::PSGI
Summary: Missing dependency on CGI::Emulate::PSGI
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 23:51 UTC by David Cook
Modified: 2018-05-01 21:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 17421: Add Devel::Size and Plack::Middleware::Debug as Perl dependency (1.66 KB, patch)
2017-04-24 14:44 UTC, Lari Taskula
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2016-10-10 23:51:11 UTC
I just tried to do a plackup (the Plack utility not plackup.sh) and got an error that CGI::Emulate::PSGI wasn't installed.

I'm thinking we should add that to Koha's Perl dependencies.

Looking at Debian (https://packages.debian.org/sid/perl/libplack-perl), it looks like the package is recommended but not required. 

Actually, I don't notice it in https://github.com/Koha-Community/Koha/blob/master/debian/control either...

I'm using Plack v1.0037 whereas Jessie is at v1.0033-1...

It's required by Plack::App::WrapCGI, which uses it in v1.0033: https://metacpan.org/source/MIYAGAWA/Plack-1.0033/lib/Plack/App/WrapCGI.pm
Comment 1 David Cook 2016-10-10 23:53:47 UTC
Actually, now that I'm installing dependencies, it seems like there's quite a few...

CGI::Emulate::PSGI
CGI::Compile
Plack::Middleware::Debug
Devel::Size
Comment 2 David Cook 2016-10-11 00:12:25 UTC
Plack::Handler::Starman
Comment 3 Lari Taskula 2017-04-24 14:44:04 UTC
I got the same errors for Plack::Middleware::Debug and Devel::Size.
Comment 4 Lari Taskula 2017-04-24 14:44:22 UTC
Created attachment 62610 [details] [review]
Bug 17421: Add Devel::Size and Plack::Middleware::Debug as Perl dependency

After fresh install, starting Plack throws the following errors:

Error while loading /home/koha/Koha/misc/plack/plack.psgi: Can't locate
Devel/Size.pm in @INC (you may need to install the Devel::Size module)

Error while loading /home/koha/Koha/misc/plack/plack.psgi: Can't locate
Plack/Middleware/Debug.pm in @INC (you may need to install the
Plack::Middleware::Debug module)

This patch adds Devel::Size and Plack::Middleware::Debug to Perl dependencies.

sudo cpanm Devel::Size
sudo cpanm Plack::Middleware::Debug