Summary: | Use https for Baker and Taylor cover images | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | m.de.rooy, martin.renvoize, mwynkoop |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20737: Use https for baker and taylor cover images
Bug 20737: Use https for baker and taylor cover images Bug 20737: Use https for baker and taylor cover images |
Description
Nick Clemens (kidclamp)
2018-05-09 11:50:06 UTC
Created attachment 75204 [details] [review] Bug 20737: Use https for baker and taylor cover images Easy change, should be able to verify with code review or testing with dummy values To test: 1 - Put some values in baker and taylor prefs (don't need to be valid) 2 - Do a search on the opac (and have some items with isbns) 3 - Inspect the cover images links to ensure they are formed correctly 4 - prove -v t/External/BakerTaylor.t Created attachment 75230 [details] [review] Bug 20737: Use https for baker and taylor cover images Easy change, should be able to verify with code review or testing with dummy values To test: 1 - Put some values in baker and taylor prefs (don't need to be valid) 2 - Do a search on the opac (and have some items with isbns) 3 - Inspect the cover images links to ensure they are formed correctly 4 - prove -v t/External/BakerTaylor.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hmm, hardcoded URLs like http://contentcafe2.btol.com in various scripts. I do not object to pushing this fix, but it would be better to remove them from the code and put them somewhere else (pref, koha-conf, etc.) Created attachment 75250 [details] [review] Bug 20737: Use https for baker and taylor cover images Easy change, should be able to verify with code review or testing with dummy values To test: 1 - Put some values in baker and taylor prefs (don't need to be valid) 2 - Do a search on the opac (and have some items with isbns) 3 - Inspect the cover images links to ensure they are formed correctly 4 - prove -v t/External/BakerTaylor.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.05, thanks to everybody involved! |