|
Description
Martin Renvoize (ashimema)
2018-05-18 13:50:16 UTC
Created attachment 75439 [details] [review] Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI Created attachment 75440 [details] [review] Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI * + $schema->resultset('Aqorder') [...]
=> We have Koha::Acquisition::Order
* Tests?
Created attachment 81730 [details] [review] Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI Created attachment 81731 [details] [review] Bug 20780: (follow-up) Use Koha::Object Moved to Koha::Object (reason for not doing so before was consistency.. the rest of Koha::EDI uses dbic directly) No tests.. yup.. because it would entail writing tests for all of Koha::EDI which currently don't exist. Created attachment 93672 [details] [review] Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 93673 [details] [review] Bug 20780: (follow-up) Use Koha::Object Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 93946 [details] [review] Bug 20780: Add handling for AcqItemSetSubfieldsWhenRecieved in EDI Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93947 [details] [review] Bug 20780: (follow-up) Use Koha::Object Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Passing QA on this as agreed with RM - both parties heavily using EDIFACT have been involved in the QA process. Tests and QA script pass. Nice work! Pushed to master for 19.11.00 |